Skip to content

Commit 3ed770f

Browse files
ringlejdavem330
authored andcommitted
net: encx24j600: Fix mask to update LED configuration
This fixes the mask used to update the LED configuration so that it clears the necessary bits as well as setting the bits according to the mask. Also reverse the LED configuration to show the Link state + collisions in LEDA and the Link state + TX/RX events in LEDB. Signed-off-by: Jon Ringle <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent da92bf9 commit 3ed770f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/ethernet/microchip/encx24j600.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -617,10 +617,10 @@ static int encx24j600_hw_init(struct encx24j600_priv *priv)
617617
(eidled & REVID_MASK) >> REVID_SHIFT);
618618

619619
/* PHY Leds: link status,
620-
* LEDA: Link + transmit/receive events
621-
* LEDB: Link State + colision events
620+
* LEDA: Link State + collision events
621+
* LEDB: Link State + transmit/receive events
622622
*/
623-
encx24j600_update_reg(priv, EIDLED, 0xbc00, 0xbc00);
623+
encx24j600_update_reg(priv, EIDLED, 0xff00, 0xcb00);
624624

625625
/* Loopback disabled */
626626
encx24j600_write_reg(priv, MACON1, 0x9);

0 commit comments

Comments
 (0)