Skip to content

Commit 3f8b963

Browse files
honkikodavem330
authored andcommitted
veth: remove redundant call of dev_alloc_name
it's called in the following register_netdevice. No need to call it here. Tested with "ip link add type veth" and "ip link add xxx%d type veth". Signed-off-by: Hong Zhiguo <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 7a6e288 commit 3f8b963

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/net/veth.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -379,12 +379,6 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
379379
else
380380
snprintf(dev->name, IFNAMSIZ, DRV_NAME "%%d");
381381

382-
if (strchr(dev->name, '%')) {
383-
err = dev_alloc_name(dev, dev->name);
384-
if (err < 0)
385-
goto err_alloc_name;
386-
}
387-
388382
err = register_netdevice(dev);
389383
if (err < 0)
390384
goto err_register_dev;
@@ -404,7 +398,6 @@ static int veth_newlink(struct net *src_net, struct net_device *dev,
404398

405399
err_register_dev:
406400
/* nothing to do */
407-
err_alloc_name:
408401
err_configure_peer:
409402
unregister_netdevice(peer);
410403
return err;

0 commit comments

Comments
 (0)