Skip to content

Commit 3f9b977

Browse files
asbjornstdavem330
authored andcommitted
net: l2tp: fix negative assignment to unsigned int
recv_seq, send_seq and lns_mode mode are all defined as unsigned int foo:1; Signed-off-by: Asbjoern Sloth Toennesen <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 57ceb86 commit 3f9b977

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

net/l2tp/l2tp_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -715,7 +715,7 @@ void l2tp_recv_common(struct l2tp_session *session, struct sk_buff *skb,
715715
l2tp_info(session, L2TP_MSG_SEQ,
716716
"%s: requested to enable seq numbers by LNS\n",
717717
session->name);
718-
session->send_seq = -1;
718+
session->send_seq = 1;
719719
l2tp_session_set_header_len(session, tunnel->version);
720720
}
721721
} else {

net/l2tp/l2tp_ppp.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1272,7 +1272,7 @@ static int pppol2tp_session_setsockopt(struct sock *sk,
12721272
err = -EINVAL;
12731273
break;
12741274
}
1275-
session->recv_seq = val ? -1 : 0;
1275+
session->recv_seq = !!val;
12761276
l2tp_info(session, PPPOL2TP_MSG_CONTROL,
12771277
"%s: set recv_seq=%d\n",
12781278
session->name, session->recv_seq);
@@ -1283,7 +1283,7 @@ static int pppol2tp_session_setsockopt(struct sock *sk,
12831283
err = -EINVAL;
12841284
break;
12851285
}
1286-
session->send_seq = val ? -1 : 0;
1286+
session->send_seq = !!val;
12871287
{
12881288
struct sock *ssk = ps->sock;
12891289
struct pppox_sock *po = pppox_sk(ssk);
@@ -1301,7 +1301,7 @@ static int pppol2tp_session_setsockopt(struct sock *sk,
13011301
err = -EINVAL;
13021302
break;
13031303
}
1304-
session->lns_mode = val ? -1 : 0;
1304+
session->lns_mode = !!val;
13051305
l2tp_info(session, PPPOL2TP_MSG_CONTROL,
13061306
"%s: set lns_mode=%d\n",
13071307
session->name, session->lns_mode);

0 commit comments

Comments
 (0)