Skip to content

Commit 3ffecef

Browse files
cminyardgregkh
authored andcommitted
ipmi:bt: Set the timeout before doing a capabilities check
commit fe50a7d upstream. There was one place where the timeout value for an operation was not being set, if a capabilities request was done from idle. Move the timeout value setting to before where that change might be requested. IMHO the cause here is the invisible returns in the macros. Maybe that's a job for later, though. Reported-by: Nordmark Claes <[email protected]> Signed-off-by: Corey Minyard <[email protected]> Cc: [email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 26e03f8 commit 3ffecef

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/char/ipmi/ipmi_bt_sm.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,11 +522,12 @@ static enum si_sm_result bt_event(struct si_sm_data *bt, long time)
522522
if (status & BT_H_BUSY) /* clear a leftover H_BUSY */
523523
BT_CONTROL(BT_H_BUSY);
524524

525+
bt->timeout = bt->BT_CAP_req2rsp;
526+
525527
/* Read BT capabilities if it hasn't been done yet */
526528
if (!bt->BT_CAP_outreqs)
527529
BT_STATE_CHANGE(BT_STATE_CAPABILITIES_BEGIN,
528530
SI_SM_CALL_WITHOUT_DELAY);
529-
bt->timeout = bt->BT_CAP_req2rsp;
530531
BT_SI_SM_RETURN(SI_SM_IDLE);
531532

532533
case BT_STATE_XACTION_START:

0 commit comments

Comments
 (0)