Skip to content

Commit 40c9e4f

Browse files
scosumarckleinebudde
authored andcommitted
can: tcan4x5x: Remove invalid write in clear_interrupts
Register 0x824 TCAN4X5X_MCAN_INT_REG is a read-only register. Any writes to this register do not have any effect. Remove this write. The m_can driver aldready clears the interrupts in m_can_isr() by writing to M_CAN_IR which is translated to register 0x1050 which is a writable version of this register. Fixes: 5443c22 ("can: tcan4x5x: Add tcan4x5x driver to the kernel") Signed-off-by: Markus Schneider-Pargmann <[email protected]> Link: https://lore.kernel.org/all/[email protected] Signed-off-by: Marc Kleine-Budde <[email protected]>
1 parent e2f1c8c commit 40c9e4f

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/net/can/m_can/tcan4x5x-core.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,11 +204,6 @@ static int tcan4x5x_clear_interrupts(struct m_can_classdev *cdev)
204204
if (ret)
205205
return ret;
206206

207-
ret = tcan4x5x_write_tcan_reg(cdev, TCAN4X5X_MCAN_INT_REG,
208-
TCAN4X5X_ENABLE_MCAN_INT);
209-
if (ret)
210-
return ret;
211-
212207
ret = tcan4x5x_write_tcan_reg(cdev, TCAN4X5X_INT_FLAGS,
213208
TCAN4X5X_CLEAR_ALL_INT);
214209
if (ret)

0 commit comments

Comments
 (0)