Skip to content

Commit 40fbbce

Browse files
Ganesh Goudardavem330
authored andcommitted
cxgb4: ptp_clock_register() returns error pointers
Check ptp_clock_register() return not only for NULL but also for error pointers, and also nullify adapter->ptp_clock if ptp_clock_register() fails. Fixes: 9c33e42 ("cxgb4: Add PTP Hardware Clock (PHC) support") Reported-by: Dan Carpenter <[email protected]> Cc: Richard Cochran <[email protected]> Signed-off-by: Ganesh Goudar <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 1e4babe commit 40fbbce

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,8 @@ void cxgb4_ptp_init(struct adapter *adapter)
441441

442442
adapter->ptp_clock = ptp_clock_register(&adapter->ptp_clock_info,
443443
&adapter->pdev->dev);
444-
if (!adapter->ptp_clock) {
444+
if (IS_ERR_OR_NULL(adapter->ptp_clock)) {
445+
adapter->ptp_clock = NULL;
445446
dev_err(adapter->pdev_dev,
446447
"PTP %s Clock registration has failed\n", __func__);
447448
return;

0 commit comments

Comments
 (0)