Skip to content

Commit 413c2f3

Browse files
Himanshu Madhanimartinkpetersen
authored andcommitted
scsi: qla2xxx: Fix setting lower transfer speed if GPSC fails
This patch prevents driver from setting lower default speed of 1 GB/sec, if the switch does not support Get Port Speed Capabilities (GPSC) command. Setting this default speed results into much lower write performance for large sequential WRITE. This patch modifies driver to check for gpsc_supported flags and prevents driver from issuing MBC_SET_PORT_PARAM (001Ah) to set default speed of 1 GB/sec. If driver does not send this mailbox command, firmware assumes maximum supported link speed and will operate at the max speed. Cc: [email protected] Signed-off-by: Himanshu Madhani <[email protected]> Reported-by: Eda Zhou <[email protected]> Reviewed-by: Ewan D. Milne <[email protected]> Tested-by: Ewan D. Milne <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 0d98ba8 commit 413c2f3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/scsi/qla2xxx/qla_init.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5037,7 +5037,8 @@ qla2x00_iidma_fcport(scsi_qla_host_t *vha, fc_port_t *fcport)
50375037
return;
50385038

50395039
if (fcport->fp_speed == PORT_SPEED_UNKNOWN ||
5040-
fcport->fp_speed > ha->link_data_rate)
5040+
fcport->fp_speed > ha->link_data_rate ||
5041+
!ha->flags.gpsc_supported)
50415042
return;
50425043

50435044
rval = qla2x00_set_idma_speed(vha, fcport->loop_id, fcport->fp_speed,

0 commit comments

Comments
 (0)