[PATCH] Fix sg_page_malloc() memset

Hugh Dickins · Linus Torvalds · commit 41ed16fa4735 · 2006-01-09T12:57:05.000-08:00
sg_page_malloc should clear the data buffer, not that extent of mem_map.

This fixes Jesper's sg_page_free "Bad page states"

Signed-off-by: Hugh Dickins &lt;hugh@veritas.com&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@osdl.org&gt;
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
@@ -2493,7 +2493,7 @@ sg_page_malloc(int rqSz, int lowDma, int *retSzp)
 	}
 	if (resp) {
 		if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO))
-			memset(resp, 0, resSz);
+			memset(page_address(resp), 0, resSz);
 		if (retSzp)
 			*retSzp = resSz;
 	}

Original file line number	Diff line number	Diff line change
`@@ -2493,7 +2493,7 @@ sg_page_malloc(int rqSz, int lowDma, int *retSzp)`
`2493`	`2493`	`}`
`2494`	`2494`	`if (resp) {`
`2495`	`2495`	`if (!capable(CAP_SYS_ADMIN) \|\| !capable(CAP_SYS_RAWIO))`
`2496`		`- memset(resp, 0, resSz);`
	`2496`	`+ memset(page_address(resp), 0, resSz);`
`2497`	`2497`	`if (retSzp)`
`2498`	`2498`	`*retSzp = resSz;`
`2499`	`2499`	`}`