Skip to content

Commit 422485d

Browse files
ffainellicomputersforpeace
authored andcommitted
mtd: nand: brcmnand: Change BUG_ON in brcmnand_send_cmd
Change the BUG_ON() condition in brcmnand_send_cmd() which checks for the interrupt status "controller ready" bit to a WARN_ON. There is no good reason to kill the system when this condition occur because we could have systems which listed the NAND controller as available (e.g: from Device Tree), but the NAND chip could be malfunctioning and not responding. Signed-off-by: Florian Fainelli <[email protected]> Acked-by: Brian Norris <[email protected]> Reviewed-by: Kamal Dasu <[email protected]> Signed-off-by: Brian Norris <[email protected]>
1 parent 79ad07d commit 422485d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mtd/nand/brcmnand/brcmnand.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1165,7 +1165,7 @@ static void brcmnand_send_cmd(struct brcmnand_host *host, int cmd)
11651165
ctrl->cmd_pending = cmd;
11661166

11671167
intfc = brcmnand_read_reg(ctrl, BRCMNAND_INTFC_STATUS);
1168-
BUG_ON(!(intfc & INTFC_CTLR_READY));
1168+
WARN_ON(!(intfc & INTFC_CTLR_READY));
11691169

11701170
mb(); /* flush previous writes */
11711171
brcmnand_write_reg(ctrl, BRCMNAND_CMD_START,

0 commit comments

Comments
 (0)