Skip to content

Commit 424f73b

Browse files
heicarstdavem330
authored andcommitted
lcs: get rid of compile warning
-Wunused-but-set-variable generates a compile warning for lcs' tasklet function. Invoked functions contain already error handling; thus additional return code checking is not needed here. Signed-off-by: Heiko Carstens <[email protected]> Signed-off-by: Frank Blaschka <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 38ed18f commit 424f73b

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

drivers/s390/net/lcs.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1483,7 +1483,6 @@ lcs_tasklet(unsigned long data)
14831483
struct lcs_channel *channel;
14841484
struct lcs_buffer *iob;
14851485
int buf_idx;
1486-
int rc;
14871486

14881487
channel = (struct lcs_channel *) data;
14891488
LCS_DBF_TEXT_(5, trace, "tlet%s", dev_name(&channel->ccwdev->dev));
@@ -1500,14 +1499,11 @@ lcs_tasklet(unsigned long data)
15001499
channel->buf_idx = buf_idx;
15011500

15021501
if (channel->state == LCS_CH_STATE_STOPPED)
1503-
// FIXME: what if rc != 0 ??
1504-
rc = lcs_start_channel(channel);
1502+
lcs_start_channel(channel);
15051503
spin_lock_irqsave(get_ccwdev_lock(channel->ccwdev), flags);
15061504
if (channel->state == LCS_CH_STATE_SUSPENDED &&
1507-
channel->iob[channel->io_idx].state == LCS_BUF_STATE_READY) {
1508-
// FIXME: what if rc != 0 ??
1509-
rc = __lcs_resume_channel(channel);
1510-
}
1505+
channel->iob[channel->io_idx].state == LCS_BUF_STATE_READY)
1506+
__lcs_resume_channel(channel);
15111507
spin_unlock_irqrestore(get_ccwdev_lock(channel->ccwdev), flags);
15121508

15131509
/* Something happened on the channel. Wake up waiters. */

0 commit comments

Comments
 (0)