Skip to content

Commit 42cd548

Browse files
pjvuurendavem330
authored andcommitted
nfp: flower: remove vlan CFI bit from push vlan action
We no longer set CFI when pushing vlan tags, therefore we remove the CFI bit from push vlan. Fixes: 1a1e586 ("nfp: add basic action capabilities to flower offloads") Signed-off-by: Pieter Jansen van Vuuren <[email protected]> Signed-off-by: Louis Peens <[email protected]> Reviewed-by: Jakub Kicinski <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent f7ee799 commit 42cd548

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

drivers/net/ethernet/netronome/nfp/flower/action.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@ nfp_fl_push_vlan(struct nfp_fl_push_vlan *push_vlan,
4848

4949
tmp_push_vlan_tci =
5050
FIELD_PREP(NFP_FL_PUSH_VLAN_PRIO, act->vlan.prio) |
51-
FIELD_PREP(NFP_FL_PUSH_VLAN_VID, act->vlan.vid) |
52-
NFP_FL_PUSH_VLAN_CFI;
51+
FIELD_PREP(NFP_FL_PUSH_VLAN_VID, act->vlan.vid);
5352
push_vlan->vlan_tci = cpu_to_be16(tmp_push_vlan_tci);
5453
}
5554

drivers/net/ethernet/netronome/nfp/flower/cmsg.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@
8282
#define NFP_FL_OUT_FLAGS_TYPE_IDX GENMASK(2, 0)
8383

8484
#define NFP_FL_PUSH_VLAN_PRIO GENMASK(15, 13)
85-
#define NFP_FL_PUSH_VLAN_CFI BIT(12)
8685
#define NFP_FL_PUSH_VLAN_VID GENMASK(11, 0)
8786

8887
#define IPV6_FLOW_LABEL_MASK cpu_to_be32(0x000fffff)

0 commit comments

Comments
 (0)