Skip to content

Commit 43ade6a

Browse files
nathanchanceJeff Kirsher
authored andcommitted
i40e: Use proper enum in i40e_ndo_set_vf_link_state
Clang warns when one enumerated type is converted implicitly to another. drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:4214:42: warning: implicit conversion from enumeration type 'enum i40e_aq_link_speed' to different enumeration type 'enum virtchnl_link_speed' [-Wenum-conversion] pfe.event_data.link_event.link_speed = I40E_LINK_SPEED_40GB; ~ ^~~~~~~~~~~~~~~~~~~~ 1 warning generated. Use the proper enum from virtchnl_link_speed, which has the same value as I40E_LINK_SPEED_40GB, VIRTCHNL_LINK_SPEED_40GB. This appears to be missed by commit ff3f4cc ("virtchnl: finish conversion to virtchnl interface"). Link: ClangBuiltLinux/linux#81 Signed-off-by: Nathan Chancellor <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 617cc64 commit 43ade6a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4256,7 +4256,7 @@ int i40e_ndo_set_vf_link_state(struct net_device *netdev, int vf_id, int link)
42564256
vf->link_forced = true;
42574257
vf->link_up = true;
42584258
pfe.event_data.link_event.link_status = true;
4259-
pfe.event_data.link_event.link_speed = I40E_LINK_SPEED_40GB;
4259+
pfe.event_data.link_event.link_speed = VIRTCHNL_LINK_SPEED_40GB;
42604260
break;
42614261
case IFLA_VF_LINK_STATE_DISABLE:
42624262
vf->link_forced = true;

0 commit comments

Comments
 (0)