net: gemini: fix memory leak

ipylypiv · davem330 · commit 44caebd368a5 · 2018-03-20T12:08:45.000-04:00
cppcheck report:
[drivers/net/ethernet/cortina/gemini.c:543]: (error) Memory leak: skb_tab

Signed-off-by: Igor Pylypiv &lt;igor.pylypiv@gmail.com&gt;
Acked-by: Linus Walleij &lt;linus.walleij@linaro.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
@@ -540,6 +540,7 @@ static int gmac_setup_txqs(struct net_device *netdev)
 
 	if (port->txq_dma_base & ~DMA_Q_BASE_MASK) {
 		dev_warn(geth->dev, "TX queue base it not aligned\n");
+		kfree(skb_tab);
 		return -ENOMEM;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -540,6 +540,7 @@ static int gmac_setup_txqs(struct net_device *netdev)`
`540`	`540`
`541`	`541`	`if (port->txq_dma_base & ~DMA_Q_BASE_MASK) {`
`542`	`542`	`dev_warn(geth->dev, "TX queue base it not aligned\n");`
	`543`	`+ kfree(skb_tab);`
`543`	`544`	`return -ENOMEM;`
`544`	`545`	`}`
`545`	`546`