Skip to content

Commit 4609adc

Browse files
mkalderondavem330
authored andcommitted
qede: Fix qedr link update
Link updates were not reported to qedr correctly. Leading to cases where a link could be down, but qedr would see it as up. In addition, once qede was loaded, link state would be up, regardless of the actual link state. Signed-off-by: Michal Kalderon <[email protected]> Signed-off-by: Ariel Elior <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b225598 commit 4609adc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/ethernet/qlogic/qede/qede_main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2067,8 +2067,6 @@ static int qede_load(struct qede_dev *edev, enum qede_load_mode mode,
20672067
link_params.link_up = true;
20682068
edev->ops->common->set_link(edev->cdev, &link_params);
20692069

2070-
qede_rdma_dev_event_open(edev);
2071-
20722070
edev->state = QEDE_STATE_OPEN;
20732071

20742072
DP_INFO(edev, "Ending successfully qede load\n");
@@ -2169,12 +2167,14 @@ static void qede_link_update(void *dev, struct qed_link_output *link)
21692167
DP_NOTICE(edev, "Link is up\n");
21702168
netif_tx_start_all_queues(edev->ndev);
21712169
netif_carrier_on(edev->ndev);
2170+
qede_rdma_dev_event_open(edev);
21722171
}
21732172
} else {
21742173
if (netif_carrier_ok(edev->ndev)) {
21752174
DP_NOTICE(edev, "Link is down\n");
21762175
netif_tx_disable(edev->ndev);
21772176
netif_carrier_off(edev->ndev);
2177+
qede_rdma_dev_event_close(edev);
21782178
}
21792179
}
21802180
}

0 commit comments

Comments
 (0)