Skip to content

Commit 467fb18

Browse files
computersforpeacemmind
authored andcommitted
ARM: dts: rockchip: correct regulator power states for suspend
When getting translated from a downstream device tree that used slightly different DT bindings, these regulators got labeled with the "on-in-suspend" state, when they were actually supposed to be turned off for S3 suspend. This was harmless, but not intentional, AFAICT. Let's turn them off to get the optimal power state. Signed-off-by: Brian Norris <[email protected]> Reviewed-by: Javier Martinez Canillas <[email protected]> Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 6a414e4 commit 467fb18

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

arch/arm/boot/dts/rk3288-veyron-jerry.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
regulator-min-microvolt = <1800000>;
100100
regulator-max-microvolt = <1800000>;
101101
regulator-state-mem {
102-
regulator-on-in-suspend;
102+
regulator-off-in-suspend;
103103
};
104104
};
105105
};

arch/arm/boot/dts/rk3288-veyron-pinky.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@
109109
regulator-boot-on;
110110
regulator-name = "vcc18_lcd";
111111
regulator-state-mem {
112-
regulator-on-in-suspend;
112+
regulator-off-in-suspend;
113113
};
114114
};
115115
};

arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@
9393
regulator-min-microvolt = <3300000>;
9494
regulator-max-microvolt = <3300000>;
9595
regulator-state-mem {
96-
regulator-on-in-suspend;
96+
regulator-off-in-suspend;
9797
};
9898
};
9999

@@ -102,7 +102,7 @@
102102
regulator-min-microvolt = <3300000>;
103103
regulator-max-microvolt = <3300000>;
104104
regulator-state-mem {
105-
regulator-on-in-suspend;
105+
regulator-off-in-suspend;
106106
};
107107
};
108108
};

0 commit comments

Comments
 (0)