Skip to content

Commit 46a4d67

Browse files
Lai Jiangshanhtejun
authored andcommitted
workqueue: Avoid a false warning in unbind_workers()
Doing set_cpus_allowed_ptr() with wq_unbound_cpumask can be possible fails and trigger the false warning. Use cpu_possible_mask instead when wq_unbound_cpumask has no active CPUs. It is very easy to trigger the warning: Set wq_unbound_cpumask to a small set of CPUs. Offline all the CPUs of wq_unbound_cpumask. Offline an extra CPU and trigger the warning. Fixes: 10a5a65 ("workqueue: Restrict kworker in the offline CPU pool running on housekeeping CPUs") Signed-off-by: Lai Jiangshan <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent 8bee9dd commit 46a4d67

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

kernel/workqueue.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5001,7 +5001,10 @@ static void unbind_workers(int cpu)
50015001

50025002
for_each_pool_worker(worker, pool) {
50035003
kthread_set_per_cpu(worker->task, -1);
5004-
WARN_ON_ONCE(set_cpus_allowed_ptr(worker->task, wq_unbound_cpumask) < 0);
5004+
if (cpumask_intersects(wq_unbound_cpumask, cpu_active_mask))
5005+
WARN_ON_ONCE(set_cpus_allowed_ptr(worker->task, wq_unbound_cpumask) < 0);
5006+
else
5007+
WARN_ON_ONCE(set_cpus_allowed_ptr(worker->task, cpu_possible_mask) < 0);
50055008
}
50065009

50075010
mutex_unlock(&wq_pool_attach_mutex);

0 commit comments

Comments
 (0)