Skip to content

Commit 47010c0

Browse files
Muchun Songakpm00
authored andcommitted
mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP*
The word of "free" is not expressive enough to express the feature of optimizing vmemmap pages associated with each HugeTLB, rename this keywork to "optimize". In this patch , cheanup configs to make code more expressive. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Muchun Song <[email protected]> Cc: Mike Kravetz <[email protected]> Cc: David Hildenbrand <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent f10f144 commit 47010c0

File tree

14 files changed

+27
-27
lines changed

14 files changed

+27
-27
lines changed

Documentation/admin-guide/kernel-parameters.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1660,7 +1660,7 @@
16601660
Format: size[KMG]
16611661

16621662
hugetlb_free_vmemmap=
1663-
[KNL] Reguires CONFIG_HUGETLB_PAGE_FREE_VMEMMAP
1663+
[KNL] Reguires CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
16641664
enabled.
16651665
Allows heavy hugetlb users to free up some more
16661666
memory (7 * PAGE_SIZE for each 2MB hugetlb page).
@@ -1669,7 +1669,7 @@
16691669
on: enable the feature
16701670
off: disable the feature
16711671

1672-
Built with CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON=y,
1672+
Built with CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON=y,
16731673
the default is on.
16741674

16751675
This is not compatible with memory_hotplug.memmap_on_memory.

Documentation/admin-guide/mm/hugetlbpage.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ default_hugepagesz
164164
will all result in 256 2M huge pages being allocated. Valid default
165165
huge page size is architecture dependent.
166166
hugetlb_free_vmemmap
167-
When CONFIG_HUGETLB_PAGE_FREE_VMEMMAP is set, this enables freeing
167+
When CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP is set, this enables optimizing
168168
unused vmemmap pages associated with each HugeTLB page.
169169

170170
When multiple huge page sizes are supported, ``/proc/sys/vm/nr_hugepages``

arch/arm64/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ config ARM64
9797
select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT
9898
select ARCH_WANT_FRAME_POINTERS
9999
select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36)
100-
select ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP
100+
select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
101101
select ARCH_WANT_LD_ORPHAN_WARN
102102
select ARCH_WANTS_NO_INSTR
103103
select ARCH_HAS_UBSAN_SANITIZE_ALL

arch/arm64/mm/flush.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ void flush_dcache_page(struct page *page)
7878
/*
7979
* Only the head page's flags of HugeTLB can be cleared since the tail
8080
* vmemmap pages associated with each HugeTLB page are mapped with
81-
* read-only when CONFIG_HUGETLB_PAGE_FREE_VMEMMAP is enabled (more
81+
* read-only when CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP is enabled (more
8282
* details can refer to vmemmap_remap_pte()). Although
8383
* __sync_icache_dcache() only set PG_dcache_clean flag on the head
8484
* page struct, there is more than one page struct with PG_dcache_clean

arch/x86/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ config X86
121121
select ARCH_WANTS_NO_INSTR
122122
select ARCH_WANT_GENERAL_HUGETLB
123123
select ARCH_WANT_HUGE_PMD_SHARE
124-
select ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP if X86_64
124+
select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP if X86_64
125125
select ARCH_WANT_LD_ORPHAN_WARN
126126
select ARCH_WANTS_THP_SWAP if X86_64
127127
select ARCH_HAS_PARANOID_L1D_FLUSH

arch/x86/mm/init_64.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1269,7 +1269,7 @@ static struct kcore_list kcore_vsyscall;
12691269

12701270
static void __init register_page_bootmem_info(void)
12711271
{
1272-
#if defined(CONFIG_NUMA) || defined(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP)
1272+
#if defined(CONFIG_NUMA) || defined(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP)
12731273
int i;
12741274

12751275
for_each_online_node(i)

fs/Kconfig

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -250,22 +250,22 @@ config HUGETLB_PAGE
250250
# to enable the feature of minimizing overhead of struct page associated with
251251
# each HugeTLB page.
252252
#
253-
config ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP
253+
config ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
254254
bool
255255

256-
config HUGETLB_PAGE_FREE_VMEMMAP
256+
config HUGETLB_PAGE_OPTIMIZE_VMEMMAP
257257
def_bool HUGETLB_PAGE
258-
depends on ARCH_WANT_HUGETLB_PAGE_FREE_VMEMMAP
258+
depends on ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
259259
depends on SPARSEMEM_VMEMMAP
260260

261-
config HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON
262-
bool "Default freeing vmemmap pages of HugeTLB to on"
261+
config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON
262+
bool "Default optimizing vmemmap pages of HugeTLB to on"
263263
default n
264-
depends on HUGETLB_PAGE_FREE_VMEMMAP
264+
depends on HUGETLB_PAGE_OPTIMIZE_VMEMMAP
265265
help
266-
When using HUGETLB_PAGE_FREE_VMEMMAP, the freeing unused vmemmap
266+
When using HUGETLB_PAGE_OPTIMIZE_VMEMMAP, the optimizing unused vmemmap
267267
pages associated with each HugeTLB page is default off. Say Y here
268-
to enable freeing vmemmap pages of HugeTLB by default. It can then
268+
to enable optimizing vmemmap pages of HugeTLB by default. It can then
269269
be disabled on the command line via hugetlb_free_vmemmap=off.
270270

271271
config MEMFD_CREATE

include/linux/hugetlb.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ struct hstate {
623623
unsigned int nr_huge_pages_node[MAX_NUMNODES];
624624
unsigned int free_huge_pages_node[MAX_NUMNODES];
625625
unsigned int surplus_huge_pages_node[MAX_NUMNODES];
626-
#ifdef CONFIG_HUGETLB_PAGE_FREE_VMEMMAP
626+
#ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
627627
unsigned int optimize_vmemmap_pages;
628628
#endif
629629
#ifdef CONFIG_CGROUP_HUGETLB

include/linux/mm.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3145,7 +3145,7 @@ static inline void print_vma_addr(char *prefix, unsigned long rip)
31453145
}
31463146
#endif
31473147

3148-
#ifdef CONFIG_HUGETLB_PAGE_FREE_VMEMMAP
3148+
#ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
31493149
int vmemmap_remap_free(unsigned long start, unsigned long end,
31503150
unsigned long reuse);
31513151
int vmemmap_remap_alloc(unsigned long start, unsigned long end,

include/linux/page-flags.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,13 +190,13 @@ enum pageflags {
190190

191191
#ifndef __GENERATING_BOUNDS_H
192192

193-
#ifdef CONFIG_HUGETLB_PAGE_FREE_VMEMMAP
194-
DECLARE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON,
193+
#ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
194+
DECLARE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON,
195195
hugetlb_optimize_vmemmap_key);
196196

197197
static __always_inline bool hugetlb_optimize_vmemmap_enabled(void)
198198
{
199-
return static_branch_maybe(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON,
199+
return static_branch_maybe(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON,
200200
&hugetlb_optimize_vmemmap_key);
201201
}
202202

mm/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ obj-$(CONFIG_FRONTSWAP) += frontswap.o
7777
obj-$(CONFIG_ZSWAP) += zswap.o
7878
obj-$(CONFIG_HAS_DMA) += dmapool.o
7979
obj-$(CONFIG_HUGETLBFS) += hugetlb.o
80-
obj-$(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP) += hugetlb_vmemmap.o
80+
obj-$(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP) += hugetlb_vmemmap.o
8181
obj-$(CONFIG_NUMA) += mempolicy.o
8282
obj-$(CONFIG_SPARSEMEM) += sparse.o
8383
obj-$(CONFIG_SPARSEMEM_VMEMMAP) += sparse-vmemmap.o

mm/hugetlb_vmemmap.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@
188188
#define RESERVE_VMEMMAP_NR 1U
189189
#define RESERVE_VMEMMAP_SIZE (RESERVE_VMEMMAP_NR << PAGE_SHIFT)
190190

191-
DEFINE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON,
191+
DEFINE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON,
192192
hugetlb_optimize_vmemmap_key);
193193
EXPORT_SYMBOL(hugetlb_optimize_vmemmap_key);
194194

@@ -276,7 +276,7 @@ void __init hugetlb_vmemmap_init(struct hstate *h)
276276

277277
/*
278278
* There are only (RESERVE_VMEMMAP_SIZE / sizeof(struct page)) struct
279-
* page structs that can be used when CONFIG_HUGETLB_PAGE_FREE_VMEMMAP,
279+
* page structs that can be used when CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP,
280280
* so add a BUILD_BUG_ON to catch invalid usage of the tail struct page.
281281
*/
282282
BUILD_BUG_ON(__NR_USED_SUBPAGE >=

mm/hugetlb_vmemmap.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#define _LINUX_HUGETLB_VMEMMAP_H
1111
#include <linux/hugetlb.h>
1212

13-
#ifdef CONFIG_HUGETLB_PAGE_FREE_VMEMMAP
13+
#ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
1414
int hugetlb_vmemmap_alloc(struct hstate *h, struct page *head);
1515
void hugetlb_vmemmap_free(struct hstate *h, struct page *head);
1616
void hugetlb_vmemmap_init(struct hstate *h);
@@ -41,5 +41,5 @@ static inline unsigned int hugetlb_optimize_vmemmap_pages(struct hstate *h)
4141
{
4242
return 0;
4343
}
44-
#endif /* CONFIG_HUGETLB_PAGE_FREE_VMEMMAP */
44+
#endif /* CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP */
4545
#endif /* _LINUX_HUGETLB_VMEMMAP_H */

mm/sparse-vmemmap.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
#include <asm/pgalloc.h>
3535
#include <asm/tlbflush.h>
3636

37-
#ifdef CONFIG_HUGETLB_PAGE_FREE_VMEMMAP
37+
#ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP
3838
/**
3939
* struct vmemmap_remap_walk - walk vmemmap page table
4040
*
@@ -420,7 +420,7 @@ int vmemmap_remap_alloc(unsigned long start, unsigned long end,
420420

421421
return 0;
422422
}
423-
#endif /* CONFIG_HUGETLB_PAGE_FREE_VMEMMAP */
423+
#endif /* CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP */
424424

425425
/*
426426
* Allocate a block of memory to be used to back the virtual memory map

0 commit comments

Comments
 (0)