Skip to content

Commit 47ac766

Browse files
Markgregkh
authored andcommitted
tty: serial: 8250: Revert NXP SC16C2552 workaround
Revert commit ecb988a: tty: serial: 8250: 8250_core: NXP SC16C2552 workaround The above commit causes userland application to no longer write correctly its first write to a dumb terminal connected to /dev/ttyS0. This commit seems to be the culprit. It's as though the TX FIFO is being reset during that write. What should be displayed is: PSW 80000000 INST 00000000 HALT // What is displayed is some variation of: T 00000000 HAL// Reverting this commit via this patch fixes my problem. Signed-off-by: Mark Hounschell <[email protected]> Fixes: ecb988a ("tty: serial: 8250: 8250_core: NXP SC16C2552 workaround") Cc: stable <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 60ab0fa commit 47ac766

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/tty/serial/8250/8250_port.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,7 @@ static const struct serial8250_config uart_config[] = {
9090
.name = "16550A",
9191
.fifo_size = 16,
9292
.tx_loadsz = 16,
93-
.fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10 |
94-
UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT,
93+
.fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10,
9594
.rxtrig_bytes = {1, 4, 8, 14},
9695
.flags = UART_CAP_FIFO,
9796
},

0 commit comments

Comments
 (0)