Skip to content

Commit 47b7360

Browse files
committed
x86/apic/vector: Make error return value negative
activate_managed() returns EINVAL instead of -EINVAL in case of error. While this is unlikely to happen, the positive return value would cause further malfunction at the call site. Fixes: 2db1f95 ("x86/vector: Handle managed interrupts proper") Signed-off-by: Thomas Gleixner <[email protected]> Cc: [email protected]
1 parent 9fe6299 commit 47b7360

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/kernel/apic/vector.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ static int activate_managed(struct irq_data *irqd)
413413
if (WARN_ON_ONCE(cpumask_empty(vector_searchmask))) {
414414
/* Something in the core code broke! Survive gracefully */
415415
pr_err("Managed startup for irq %u, but no CPU\n", irqd->irq);
416-
return EINVAL;
416+
return -EINVAL;
417417
}
418418

419419
ret = assign_managed_vector(irqd, vector_searchmask);

0 commit comments

Comments
 (0)