Skip to content

Commit 47b9986

Browse files
Phil Elwelldavem330
authored andcommitted
lan78xx: Don't reset the interface on open
Commit 92571a1 ("lan78xx: Connect phy early") moves the PHY initialisation into lan78xx_probe, but lan78xx_open subsequently calls lan78xx_reset. As well as forcing a second round of link negotiation, this reset frequently prevents the phy interrupt from being generated (even though the link is up), rendering the interface unusable. Fix this issue by removing the lan78xx_reset call from lan78xx_open. Fixes: 92571a1 ("lan78xx: Connect phy early") Signed-off-by: Phil Elwell <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 9cf74f5 commit 47b9986

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/net/usb/lan78xx.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2515,10 +2515,6 @@ static int lan78xx_open(struct net_device *net)
25152515
if (ret < 0)
25162516
goto out;
25172517

2518-
ret = lan78xx_reset(dev);
2519-
if (ret < 0)
2520-
goto done;
2521-
25222518
phy_start(net->phydev);
25232519

25242520
netif_dbg(dev, ifup, dev->net, "phy initialised successfully");

0 commit comments

Comments
 (0)