Skip to content

Commit 47c5ba5

Browse files
dtortorvalds
authored andcommitted
Input: ir-keytable - fix uninitialized variable warning
We were forgetting to set up proper return value in success path causing ir_getkeycode() to fail intermittently: drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function Reported-by: Stefan Richter <[email protected]> Signed-off-by: Dmitry Torokhov <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 50440c6 commit 47c5ba5

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/media/IR/ir-keytable.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,8 @@ static int ir_getkeycode(struct input_dev *dev,
389389
ke->len = sizeof(entry->scancode);
390390
memcpy(ke->scancode, &entry->scancode, sizeof(entry->scancode));
391391

392+
retval = 0;
393+
392394
out:
393395
spin_unlock_irqrestore(&rc_tab->lock, flags);
394396
return retval;

0 commit comments

Comments
 (0)