net: phy: mscc: fix memory leak in vsc8574_config_pre_init

GustavoARSilva · davem330 · commit 47d20212aa1c · 2018-10-17T22:08:55.000-07:00
In case memory resources for *fw* were successfully allocated, release them before return. Addresses-Coverity-ID: 1473968 ("Resource leak") Fixes: 00d70d8 ("net: phy: mscc: add support for VSC8574 PHY") Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c
@@ -1292,7 +1292,7 @@ static int vsc8574_config_pre_init(struct phy_device *phydev)
 				dev_err(dev,
 					"%s: failed to assert reset of micro\n",
 					__func__);
-				return ret;
+				goto out;
 			}
 		}
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -1292,7 +1292,7 @@ static int vsc8574_config_pre_init(struct phy_device *phydev)`
`1292`	`1292`	`dev_err(dev,`
`1293`	`1293`	`"%s: failed to assert reset of micro\n",`
`1294`	`1294`	`__func__);`
`1295`		`- return ret;`
	`1295`	`+ goto out;`
`1296`	`1296`	`}`
`1297`	`1297`	`}`
`1298`	`1298`	`} else {`