Skip to content

Commit 48167c9

Browse files
madalinbucurdavem330
authored andcommitted
fsl/fman: remove of_node
The FMan MAC driver allocates a platform device for the Ethernet driver to probe on. Setting pdev->dev.of_node with the MAC node triggers the MAC driver probing of the new platform device. While this fails quickly and does not affect the functionality of the drivers, it is incorrect and must be removed. This was added to address a report that DSA code using of_find_net_device_by_node() is unable to use the DPAA interfaces. Error message seen before this fix: fsl_mac dpaa-ethernet.0: __devm_request_mem_region(mac) failed fsl_mac: probe of dpaa-ethernet.0 failed with error -16 Signed-off-by: Madalin Bucur <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 2dc7c1f commit 48167c9

File tree

1 file changed

+0
-1
lines changed
  • drivers/net/ethernet/freescale/fman

1 file changed

+0
-1
lines changed

drivers/net/ethernet/freescale/fman/mac.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,6 @@ static struct platform_device *dpaa_eth_add_device(int fman_id,
623623
goto no_mem;
624624
}
625625

626-
pdev->dev.of_node = node;
627626
pdev->dev.parent = priv->dev;
628627
set_dma_ops(&pdev->dev, get_dma_ops(priv->dev));
629628

0 commit comments

Comments
 (0)