Skip to content

Commit 49f3413

Browse files
Milo KimKAGA-KOKO
authored andcommitted
irqchip/atmel-aic: Fix wrong bit operation for IRQ priority
Atmel AIC has common structure for SMR (Source Mode Register). bit[6:5] Interrupt source type bit[2:0] Priority level Other bits are unused. To update new priority value, bit[2:0] should be cleared first and then new priority level can be written. However, aic_common_set_priority() helper clears source type bits instead of priority bits. This patch fixes wrong mask bit operation. Fixes: b1479eb "irqchip: atmel-aic: Add atmel AIC/AIC5 drivers" Signed-off-by: Milo Kim <[email protected]> Acked-by: Boris Brezillon <[email protected]> Cc: Jason Cooper <[email protected]> Cc: Marc Zyngier <[email protected]> Cc: Ludovic Desroches <[email protected]> Cc: Nicholas Ferre <[email protected]> Cc: [email protected] #v3.17+ Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Thomas Gleixner <[email protected]>
1 parent 18aa60c commit 49f3413

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/irqchip/irq-atmel-aic-common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ int aic_common_set_priority(int priority, unsigned *val)
8686
priority > AT91_AIC_IRQ_MAX_PRIORITY)
8787
return -EINVAL;
8888

89-
*val &= AT91_AIC_PRIOR;
89+
*val &= ~AT91_AIC_PRIOR;
9090
*val |= priority;
9191

9292
return 0;

0 commit comments

Comments
 (0)