Skip to content

Commit 4a770e6

Browse files
committed
Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull vfs fix from Al Viro: "Followup to procfs-seq_file series this window" This fixes a memory leak by making sure that proc seq files release any private data on close. The 'proc_seq_open' has to be properly paired with 'proc_seq_release' that releases the extra private data. * 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: proc: add proc_seq_release
2 parents d7563ca + 877f919 commit 4a770e6

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

fs/proc/generic.c

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,11 +564,20 @@ static int proc_seq_open(struct inode *inode, struct file *file)
564564
return seq_open(file, de->seq_ops);
565565
}
566566

567+
static int proc_seq_release(struct inode *inode, struct file *file)
568+
{
569+
struct proc_dir_entry *de = PDE(inode);
570+
571+
if (de->state_size)
572+
return seq_release_private(inode, file);
573+
return seq_release(inode, file);
574+
}
575+
567576
static const struct file_operations proc_seq_fops = {
568577
.open = proc_seq_open,
569578
.read = seq_read,
570579
.llseek = seq_lseek,
571-
.release = seq_release,
580+
.release = proc_seq_release,
572581
};
573582

574583
struct proc_dir_entry *proc_create_seq_private(const char *name, umode_t mode,

0 commit comments

Comments
 (0)