Skip to content

Commit 4aa0b5d

Browse files
mikuintickle
authored andcommitted
drm/i915/tgl: Add HDC Pipeline Flush
Add hdc pipeline flush to ensure memory state is coherent in L3 when we are done. v2: Flush also in breadcrumbs (Chris) Cc: Chris Wilson <[email protected]> Signed-off-by: Mika Kuoppala <[email protected]> Reviewed-by: Chris Wilson <[email protected]> Signed-off-by: Chris Wilson <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 62037ff commit 4aa0b5d

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

drivers/gpu/drm/i915/gt/intel_gpu_commands.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@
235235
#define PIPE_CONTROL_TEXTURE_CACHE_INVALIDATE (1<<10) /* GM45+ only */
236236
#define PIPE_CONTROL_L3_RO_CACHE_INVALIDATE REG_BIT(10) /* gen12 */
237237
#define PIPE_CONTROL_INDIRECT_STATE_DISABLE (1<<9)
238+
#define PIPE_CONTROL_HDC_PIPELINE_FLUSH REG_BIT(9) /* gen12 */
238239
#define PIPE_CONTROL_NOTIFY (1<<8)
239240
#define PIPE_CONTROL_FLUSH_ENABLE (1<<7) /* gen7+ */
240241
#define PIPE_CONTROL_DC_FLUSH_ENABLE (1<<5)

drivers/gpu/drm/i915/gt/intel_lrc.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3205,6 +3205,7 @@ static int gen12_emit_flush_render(struct i915_request *request,
32053205
flags |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;
32063206
flags |= PIPE_CONTROL_DC_FLUSH_ENABLE;
32073207
flags |= PIPE_CONTROL_FLUSH_ENABLE;
3208+
flags |= PIPE_CONTROL_HDC_PIPELINE_FLUSH;
32083209

32093210
flags |= PIPE_CONTROL_STORE_DATA_INDEX;
32103211
flags |= PIPE_CONTROL_QW_WRITE;
@@ -3415,7 +3416,8 @@ gen12_emit_fini_breadcrumb_rcs(struct i915_request *request, u32 *cs)
34153416
PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH |
34163417
PIPE_CONTROL_DEPTH_CACHE_FLUSH |
34173418
PIPE_CONTROL_DC_FLUSH_ENABLE |
3418-
PIPE_CONTROL_FLUSH_ENABLE);
3419+
PIPE_CONTROL_FLUSH_ENABLE |
3420+
PIPE_CONTROL_HDC_PIPELINE_FLUSH);
34193421

34203422
return gen12_emit_fini_breadcrumb_footer(request, cs);
34213423
}

0 commit comments

Comments
 (0)