Skip to content

Commit 4b27a1e

Browse files
Jakub Kicinskidavem330
authored andcommitted
nfp: remove nfp_net_irqs_wanted()
nfp_net_irqs_wanted() doesn't really encapsulate much logic, remove it and inline the calculations. Signed-off-by: Jakub Kicinski <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent a4b562b commit 4b27a1e

File tree

1 file changed

+4
-23
lines changed

1 file changed

+4
-23
lines changed

drivers/net/ethernet/netronome/nfp/nfp_net_common.c

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -307,28 +307,6 @@ static int nfp_net_msix_alloc(struct nfp_net *nn, int nr_vecs)
307307
return nvecs;
308308
}
309309

310-
/**
311-
* nfp_net_irqs_wanted() - Work out how many interrupt vectors we want
312-
* @nn: NFP Network structure
313-
*
314-
* We want a vector per CPU (or ring), whatever is smaller plus
315-
* NFP_NET_NON_Q_VECTORS for LSC etc.
316-
*
317-
* Return: Number of interrupts wanted
318-
*/
319-
static int nfp_net_irqs_wanted(struct nfp_net *nn)
320-
{
321-
unsigned int vecs;
322-
int ncpus;
323-
324-
ncpus = num_online_cpus();
325-
326-
vecs = max_t(int, nn->num_tx_rings, nn->num_rx_rings);
327-
vecs = min_t(int, vecs, ncpus);
328-
329-
return vecs + NFP_NET_NON_Q_VECTORS;
330-
}
331-
332310
/**
333311
* nfp_net_irqs_alloc() - allocates MSI-X irqs
334312
* @nn: NFP Network structure
@@ -339,7 +317,7 @@ int nfp_net_irqs_alloc(struct nfp_net *nn)
339317
{
340318
int wanted_irqs;
341319

342-
wanted_irqs = nfp_net_irqs_wanted(nn);
320+
wanted_irqs = nn->num_r_vecs + NFP_NET_NON_Q_VECTORS;
343321

344322
nn->num_irqs = nfp_net_msix_alloc(nn, wanted_irqs);
345323
if (nn->num_irqs == 0) {
@@ -2726,6 +2704,9 @@ struct nfp_net *nfp_net_netdev_alloc(struct pci_dev *pdev,
27262704
nn->num_tx_rings = min_t(int, nqs, max_tx_rings);
27272705
nn->num_rx_rings = min_t(int, nqs, max_rx_rings);
27282706

2707+
nn->num_r_vecs = max(nn->num_tx_rings, nn->num_rx_rings);
2708+
nn->num_r_vecs = min_t(unsigned int, nn->num_r_vecs, num_online_cpus());
2709+
27292710
nn->txd_cnt = NFP_NET_TX_DESCS_DEFAULT;
27302711
nn->rxd_cnt = NFP_NET_RX_DESCS_DEFAULT;
27312712

0 commit comments

Comments
 (0)