Skip to content

Commit 4c3e829

Browse files
Frank PraznikJiri Kosina
authored andcommitted
HID: sony: Correct a typo in a HID descriptor comment and explain the odd Sixaxis axis mapping
Correct a spelling mistake in the Sixaxis HID descriptor comment. Add an explanation as to why the Sixaxis has so many analog axes and why some of them are seen as multi-touch axes. Signed-off-by: Frank Praznik <[email protected]> Acked-by: Pavel Machek <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 221399b commit 4c3e829

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

drivers/hid/hid-sony.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,16 @@
5959

6060
#define MAX_LEDS 4
6161

62+
/*
63+
* The Sixaxis reports both digital and analog values for each button on the
64+
* controller except for Start, Select and the PS button. The controller ends
65+
* up reporting 27 axes which causes them to spill over into the multi-touch
66+
* axis values. Additionally, the controller only has 20 actual, physical axes
67+
* so there are several unused axes in between the used ones.
68+
*/
6269
static __u8 sixaxis_rdesc[] = {
6370
0x05, 0x01, /* Usage Page (Desktop), */
64-
0x09, 0x04, /* Usage (Joystik), */
71+
0x09, 0x04, /* Usage (Joystick), */
6572
0xA1, 0x01, /* Collection (Application), */
6673
0xA1, 0x02, /* Collection (Logical), */
6774
0x85, 0x01, /* Report ID (1), */

0 commit comments

Comments
 (0)