USB: visor: fix trivial accounting bug in visor driver

Oliver Neukum · gregkh · commit 4c9fde9b860c · 2009-10-09T13:52:08.000-07:00
usb:usbserial:visor: fix accounting in error case

data not pushed to the tty layer due to an error mustn't be counted

Signed-off-by: Oliver Neukum &lt;oliver@neukum.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@suse.de&gt;
diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
@@ -513,7 +513,8 @@ static void visor_read_bulk_callback(struct urb *urb)
 			tty_kref_put(tty);
 		}
 		spin_lock(&priv->lock);
-		priv->bytes_in += available_room;
+		if (tty)
+			priv->bytes_in += available_room;
 
 	} else {
 		spin_lock(&priv->lock);

Original file line number	Diff line number	Diff line change
`@@ -513,7 +513,8 @@ static void visor_read_bulk_callback(struct urb *urb)`
`513`	`513`	`tty_kref_put(tty);`
`514`	`514`	`}`
`515`	`515`	`spin_lock(&priv->lock);`
`516`		`- priv->bytes_in += available_room;`
	`516`	`+ if (tty)`
	`517`	`+ priv->bytes_in += available_room;`
`517`	`518`
`518`	`519`	`} else {`
`519`	`520`	`spin_lock(&priv->lock);`