Skip to content

Commit 4cc683c

Browse files
Christian Lamparterlinvjw
authored andcommitted
p54: enable 2.4/5GHz spectrum by eeprom bits.
Badness at /home/proski/src/linux-2.6/net/mac80211/rx.c:2200 NIP: c02bc850 LR: c02ab268 CTR: 00000000 REGS: ef01fcc0 TRAP: 0700 Tainted: G W (2.6.27-wl) MSR: 00029032 <EE,ME,IR,DR> CR: 22004084 XER: 20000000 TASK = c1a58800[1778] 'p54pci' THREAD: ef01e000 [...] NIP [c02bc850] __ieee80211_rx+0x17c/0x638 LR [c02ab268] ieee80211_tasklet_handler+0x104/0x120 Call Trace: [ef01fd70] [c1a0c020] 0xc1a0c020 (unreliable) [ef01fdb0] [c02ab268] ieee80211_tasklet_handler+0x104/0x120 [...] the problem was that some older cards are mis-identified and didn't support 5GHz rates, while they have the right MAC & Synth chip. This patch changes the way how p54 decides if it should enable 11a channels or not. Reported-by: Pavel Roskin <[email protected]> Signed-off-by: Christian Lamparter <[email protected]> Signed-off-by: John W. Linville <[email protected]>
1 parent 7045825 commit 4cc683c

File tree

1 file changed

+10
-18
lines changed

1 file changed

+10
-18
lines changed

drivers/net/wireless/p54/p54common.c

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -306,8 +306,8 @@ static int p54_convert_rev1(struct ieee80211_hw *dev,
306306
return 0;
307307
}
308308

309-
static const char *p54_rf_chips[] = { "NULL", "Indigo?", "Duette",
310-
"Frisbee", "Xbow", "Longbow" };
309+
static const char *p54_rf_chips[] = { "NULL", "Duette3", "Duette2",
310+
"Frisbee", "Xbow", "Longbow", "NULL", "NULL" };
311311
static int p54_init_xbow_synth(struct ieee80211_hw *dev);
312312

313313
static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
@@ -319,6 +319,7 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
319319
void *tmp;
320320
int err;
321321
u8 *end = (u8 *)eeprom + len;
322+
u16 synth;
322323
DECLARE_MAC_BUF(mac);
323324

324325
wrap = (struct eeprom_pda_wrap *) eeprom;
@@ -400,8 +401,8 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
400401
tmp = entry->data;
401402
while ((u8 *)tmp < entry->data + data_len) {
402403
struct bootrec_exp_if *exp_if = tmp;
403-
if (le16_to_cpu(exp_if->if_id) == 0xF)
404-
priv->rxhw = le16_to_cpu(exp_if->variant) & 0x07;
404+
if (le16_to_cpu(exp_if->if_id) == 0xf)
405+
synth = le16_to_cpu(exp_if->variant);
405406
tmp += sizeof(struct bootrec_exp_if);
406407
}
407408
break;
@@ -427,22 +428,13 @@ static int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
427428
goto err;
428429
}
429430

430-
switch (priv->rxhw) {
431-
case 4: /* XBow */
431+
priv->rxhw = synth & 0x07;
432+
if (priv->rxhw == 4)
432433
p54_init_xbow_synth(dev);
433-
case 1: /* Indigo? */
434-
case 2: /* Duette */
435-
dev->wiphy->bands[IEEE80211_BAND_5GHZ] = &band_5GHz;
436-
case 3: /* Frisbee */
437-
case 5: /* Longbow */
434+
if (!(synth & 0x40))
438435
dev->wiphy->bands[IEEE80211_BAND_2GHZ] = &band_2GHz;
439-
break;
440-
default:
441-
printk(KERN_ERR "%s: unsupported RF-Chip\n",
442-
wiphy_name(dev->wiphy));
443-
err = -EINVAL;
444-
goto err;
445-
}
436+
if (!(synth & 0x80))
437+
dev->wiphy->bands[IEEE80211_BAND_5GHZ] = &band_5GHz;
446438

447439
if (!is_valid_ether_addr(dev->wiphy->perm_addr)) {
448440
u8 perm_addr[ETH_ALEN];

0 commit comments

Comments
 (0)