net: usb: log errors to dmesg/syslog

grundlerchromium · davem330 · commit 4d8c79b7e9ff · 2021-03-08T11:54:32.000-08:00
Errors in protocol should be logged when the driver aborts operations.
If the driver can carry on and "humor" the device, then emitting
the message as debug output level is fine.

Signed-off-by: Grant Grundler &lt;grundler@chromium.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
@@ -887,7 +887,7 @@ int usbnet_open (struct net_device *net)
 
 	// insist peer be connected
 	if (info->check_connect && (retval = info->check_connect (dev)) < 0) {
-		netif_dbg(dev, ifup, dev->net, "can't open; %d\n", retval);
+		netif_err(dev, ifup, dev->net, "can't open; %d\n", retval);
 		goto done;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -887,7 +887,7 @@ int usbnet_open (struct net_device *net)`
`887`	`887`
`888`	`888`	`// insist peer be connected`
`889`	`889`	`if (info->check_connect && (retval = info->check_connect (dev)) < 0) {`
`890`		`- netif_dbg(dev, ifup, dev->net, "can't open; %d\n", retval);`
	`890`	`+ netif_err(dev, ifup, dev->net, "can't open; %d\n", retval);`
`891`	`891`	`goto done;`
`892`	`892`	`}`
`893`	`893`