Skip to content

Commit 4d9aac3

Browse files
Guilherme G. Piccolimpe
authored andcommitted
powerpc/PCI: Disable MSI/MSI-X interrupts at PCI probe time in OF case
Since commit 1851617 ("PCI/MSI: Disable MSI at enumeration even if kernel doesn't support MSI"), the setup of dev->msi_cap/msix_cap and the disable of MSI/MSI-X interrupts isn't being done at PCI probe time, as the logic responsible for this was moved in the aforementioned commit from pci_device_add() to pci_setup_device(). The latter function is not reachable on PowerPC pseries platform during Open Firmware PCI probing time. This exhibits as drivers not being able to enable MSI, eg: bnx2x 0000:01:00.0: no msix capability found This patch calls pci_msi_setup_pci_dev() explicitly to disable MSI/MSI-X during PCI probe time on pSeries platform. Fixes: 1851617 ("PCI/MSI: Disable MSI at enumeration even if kernel doesn't support MSI") [mpe: Flesh out change log and clarify comment] Signed-off-by: Guilherme G. Piccoli <[email protected]> Signed-off-by: Michael Ellerman <[email protected]>
1 parent 22b6839 commit 4d9aac3

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

arch/powerpc/kernel/pci_of_scan.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,9 @@ struct pci_dev *of_create_pci_dev(struct device_node *node,
191191

192192
pci_device_add(dev, bus);
193193

194+
/* Setup MSI caps & disable MSI/MSI-X interrupts */
195+
pci_msi_setup_pci_dev(dev);
196+
194197
return dev;
195198
}
196199
EXPORT_SYMBOL(of_create_pci_dev);

0 commit comments

Comments
 (0)