Skip to content

Commit 4e57808

Browse files
committed
drm/vmwgfx: Fix incorrect write to read-only register v2:
Commit "drm/vmwgfx: correct fb_fix_screeninfo.line_length", while fixing a vmwgfx fbdev bug, also writes the pitch to a supposedly read-only register: SVGA_REG_BYTES_PER_LINE, while it should be (and also in fact is) written to SVGA_REG_PITCHLOCK. This patch is Cc'd stable because of the unknown effects writing to this register might have, particularly on older device versions. v2: Updated log message. Cc: [email protected] Cc: Christopher Friedt <[email protected]> Tested-by: Christopher Friedt <[email protected]> Signed-off-by: Thomas Hellstrom <[email protected]> Reviewed-by: Jakob Bornecrantz <[email protected]>
1 parent 0fcb70c commit 4e57808

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/gpu/drm/vmwgfx/vmwgfx_fb.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ static int vmw_fb_set_par(struct fb_info *info)
179179
vmw_write(vmw_priv, SVGA_REG_DISPLAY_POSITION_Y, info->var.yoffset);
180180
vmw_write(vmw_priv, SVGA_REG_DISPLAY_WIDTH, info->var.xres);
181181
vmw_write(vmw_priv, SVGA_REG_DISPLAY_HEIGHT, info->var.yres);
182-
vmw_write(vmw_priv, SVGA_REG_BYTES_PER_LINE, info->fix.line_length);
183182
vmw_write(vmw_priv, SVGA_REG_DISPLAY_ID, SVGA_ID_INVALID);
184183
}
185184

0 commit comments

Comments
 (0)