Skip to content

Commit 4f9a301

Browse files
Randy Dunlapjgunthorpe
authored andcommitted
infiniband: fix sw/rdmavt/* kernel-doc notation
Use correct parameter names and formatting in function kernel-doc notation to eliminate warnings from scripts/kernel-doc. ../drivers/infiniband/sw/rdmavt/mr.c:784: warning: Excess function parameter 'ibmfr' description in 'rvt_map_phys_fmr' ../drivers/infiniband/sw/rdmavt/vt.c:234: warning: Excess function parameter 'intex' description in 'rvt_query_pkey' ../drivers/infiniband/sw/rdmavt/vt.c:266: warning: Excess function parameter 'index' description in 'rvt_query_gid' ../drivers/infiniband/sw/rdmavt/vt.c:306: warning: Excess function parameter 'data' description in 'rvt_alloc_ucontext' ../drivers/infiniband/sw/rdmavt/cq.c:65: warning: Excess function parameter 'sig' description in 'rvt_cq_enter' ../drivers/infiniband/sw/rdmavt/qp.c:279: warning: Excess function parameter 'qpt' description in 'rvt_free_all_qps' ../drivers/infiniband/sw/rdmavt/mcast.c:282: warning: Excess function parameter 'igd' description in 'rvt_attach_mcast' ../drivers/infiniband/sw/rdmavt/mcast.c:345: warning: Excess function parameter 'igd' description in 'rvt_detach_mcast' Signed-off-by: Randy Dunlap <[email protected]> Cc: Doug Ledford <[email protected]> Cc: Jason Gunthorpe <[email protected]> Cc: [email protected] Acked-by: Dennis Dalessandro <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent cb8d094 commit 4f9a301

File tree

5 files changed

+18
-17
lines changed

5 files changed

+18
-17
lines changed

drivers/infiniband/sw/rdmavt/cq.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
* rvt_cq_enter - add a new entry to the completion queue
5757
* @cq: completion queue
5858
* @entry: work completion entry to add
59-
* @sig: true if @entry is solicited
59+
* @solicited: true if @entry is solicited
6060
*
6161
* This may be called with qp->s_lock held.
6262
*/

drivers/infiniband/sw/rdmavt/mcast.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ static int rvt_mcast_add(struct rvt_dev_info *rdi, struct rvt_ibport *ibp,
272272
/**
273273
* rvt_attach_mcast - attach a qp to a multicast group
274274
* @ibqp: Infiniband qp
275-
* @igd: multicast guid
275+
* @gid: multicast guid
276276
* @lid: multicast lid
277277
*
278278
* Return: 0 on success
@@ -335,7 +335,7 @@ int rvt_attach_mcast(struct ib_qp *ibqp, union ib_gid *gid, u16 lid)
335335
/**
336336
* rvt_detach_mcast - remove a qp from a multicast group
337337
* @ibqp: Infiniband qp
338-
* @igd: multicast guid
338+
* @gid: multicast guid
339339
* @lid: multicast lid
340340
*
341341
* Return: 0 on success

drivers/infiniband/sw/rdmavt/mr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ struct ib_fmr *rvt_alloc_fmr(struct ib_pd *pd, int mr_access_flags,
768768

769769
/**
770770
* rvt_map_phys_fmr - set up a fast memory region
771-
* @ibmfr: the fast memory region to set up
771+
* @ibfmr: the fast memory region to set up
772772
* @page_list: the list of pages to associate with the fast memory region
773773
* @list_len: the number of pages to associate with the fast memory region
774774
* @iova: the virtual address of the start of the fast memory region

drivers/infiniband/sw/rdmavt/qp.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ int rvt_driver_qp_init(struct rvt_dev_info *rdi)
269269

270270
/**
271271
* free_all_qps - check for QPs still in use
272-
* @qpt: the QP table to empty
272+
* @rdi: rvt device info structure
273273
*
274274
* There should not be any QPs still in use.
275275
* Free memory for table.
@@ -335,9 +335,9 @@ static inline unsigned mk_qpn(struct rvt_qpn_table *qpt,
335335
/**
336336
* alloc_qpn - Allocate the next available qpn or zero/one for QP type
337337
* IB_QPT_SMI/IB_QPT_GSI
338-
*@rdi: rvt device info structure
339-
*@qpt: queue pair number table pointer
340-
*@port_num: IB port number, 1 based, comes from core
338+
* @rdi: rvt device info structure
339+
* @qpt: queue pair number table pointer
340+
* @port_num: IB port number, 1 based, comes from core
341341
*
342342
* Return: The queue pair number
343343
*/
@@ -1650,9 +1650,9 @@ static inline int rvt_qp_valid_operation(
16501650

16511651
/**
16521652
* rvt_qp_is_avail - determine queue capacity
1653-
* @qp - the qp
1654-
* @rdi - the rdmavt device
1655-
* @reserved_op - is reserved operation
1653+
* @qp: the qp
1654+
* @rdi: the rdmavt device
1655+
* @reserved_op: is reserved operation
16561656
*
16571657
* This assumes the s_hlock is held but the s_last
16581658
* qp variable is uncontrolled.
@@ -2174,8 +2174,8 @@ EXPORT_SYMBOL(rvt_rc_rnr_retry);
21742174

21752175
/**
21762176
* rvt_qp_iter_init - initial for QP iteration
2177-
* @rdi - rvt devinfo
2178-
* @v - u64 value
2177+
* @rdi: rvt devinfo
2178+
* @v: u64 value
21792179
*
21802180
* This returns an iterator suitable for iterating QPs
21812181
* in the system.

drivers/infiniband/sw/rdmavt/vt.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,8 @@ static int rvt_modify_port(struct ib_device *ibdev, u8 port_num,
224224
* rvt_query_pkey - Return a pkey from the table at a given index
225225
* @ibdev: Verbs IB dev
226226
* @port_num: Port number, 1 based from ib core
227-
* @intex: Index into pkey table
227+
* @index: Index into pkey table
228+
* @pkey: returned pkey from the port pkey table
228229
*
229230
* Return: 0 on failure pkey otherwise
230231
*/
@@ -255,7 +256,7 @@ static int rvt_query_pkey(struct ib_device *ibdev, u8 port_num, u16 index,
255256
* rvt_query_gid - Return a gid from the table
256257
* @ibdev: Verbs IB dev
257258
* @port_num: Port number, 1 based from ib core
258-
* @index: = Index in table
259+
* @guid_index: Index in table
259260
* @gid: Gid to return
260261
*
261262
* Return: 0 on success
@@ -297,8 +298,8 @@ static inline struct rvt_ucontext *to_iucontext(struct ib_ucontext
297298

298299
/**
299300
* rvt_alloc_ucontext - Allocate a user context
300-
* @ibdev: Vers IB dev
301-
* @data: User data allocated
301+
* @ibdev: Verbs IB dev
302+
* @udata: User data allocated
302303
*/
303304
static struct ib_ucontext *rvt_alloc_ucontext(struct ib_device *ibdev,
304305
struct ib_udata *udata)

0 commit comments

Comments
 (0)