bonding: do not allow rlb updates to invalid mac

dbavatar · davem330 · commit 4fa8667ca398 · 2018-05-11T11:50:41.000-04:00
Make sure multicast, broadcast, and zero mac's cannot be the output of rlb
updates, which should all be directed arps. Receive load balancing will be
collapsed if any of these happen, as the switch will broadcast.

Signed-off-by: Debabrata Banerjee &lt;dbanerje@akamai.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
@@ -450,7 +450,7 @@ static void rlb_update_client(struct rlb_client_info *client_info)
 {
 	int i;
 
-	if (!client_info->slave)
+	if (!client_info->slave || !is_valid_ether_addr(client_info->mac_dst))
 		return;
 
 	for (i = 0; i < RLB_ARP_BURST_SIZE; i++) {

Original file line number	Diff line number	Diff line change
`@@ -450,7 +450,7 @@ static void rlb_update_client(struct rlb_client_info *client_info)`
`450`	`450`	`{`
`451`	`451`	`int i;`
`452`	`452`
`453`		`- if (!client_info->slave)`
	`453`	`+ if (!client_info->slave \|\| !is_valid_ether_addr(client_info->mac_dst))`
`454`	`454`	`return;`
`455`	`455`
`456`	`456`	`for (i = 0; i < RLB_ARP_BURST_SIZE; i++) {`