Skip to content

Commit 50154e2

Browse files
musicakcjanaszewski
authored andcommitted
leds: lm3533: Use devm_led_classdev_register
Switch to resource-managed function devm_led_classdev_register instead of led_classdev_register and remove unneeded led_classdev_unregister. To be compatible with this change, remove an unnecessary label by replacing it with direct return statement. The Coccinelle semantic patch used to make this change is as follows: //<smpl> @platform@ identifier p, probefn, removefn; @@ struct platform_driver p = { .probe = probefn, .remove = removefn, }; @prb@ identifier platform.probefn, pdev; expression e; @@ probefn(struct platform_device *pdev, ...) { ... e = - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } //</smpl> Signed-off-by: Amitoj Kaur Chawla <[email protected]> Signed-off-by: Jacek Anaszewski <[email protected]>
1 parent eae7c98 commit 50154e2

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

drivers/leds/leds-lm3533.c

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,7 @@ static int lm3533_led_probe(struct platform_device *pdev)
698698

699699
platform_set_drvdata(pdev, led);
700700

701-
ret = led_classdev_register(pdev->dev.parent, &led->cdev);
701+
ret = devm_led_classdev_register(pdev->dev.parent, &led->cdev);
702702
if (ret) {
703703
dev_err(&pdev->dev, "failed to register LED %d\n", pdev->id);
704704
return ret;
@@ -708,18 +708,13 @@ static int lm3533_led_probe(struct platform_device *pdev)
708708

709709
ret = lm3533_led_setup(led, pdata);
710710
if (ret)
711-
goto err_unregister;
711+
return ret;
712712

713713
ret = lm3533_ctrlbank_enable(&led->cb);
714714
if (ret)
715-
goto err_unregister;
715+
return ret;
716716

717717
return 0;
718-
719-
err_unregister:
720-
led_classdev_unregister(&led->cdev);
721-
722-
return ret;
723718
}
724719

725720
static int lm3533_led_remove(struct platform_device *pdev)
@@ -729,7 +724,6 @@ static int lm3533_led_remove(struct platform_device *pdev)
729724
dev_dbg(&pdev->dev, "%s\n", __func__);
730725

731726
lm3533_ctrlbank_disable(&led->cb);
732-
led_classdev_unregister(&led->cdev);
733727

734728
return 0;
735729
}

0 commit comments

Comments
 (0)