Skip to content

Commit 50ad480

Browse files
Philippe Reynesdavem330
authored andcommitted
net: toshiba: spider_net: use new api ethtool_{get|set}_link_ksettings
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent f441df6 commit 50ad480

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

drivers/net/ethernet/toshiba/spider_net_ethtool.c

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,19 +47,23 @@ static struct {
4747
};
4848

4949
static int
50-
spider_net_ethtool_get_settings(struct net_device *netdev,
51-
struct ethtool_cmd *cmd)
50+
spider_net_ethtool_get_link_ksettings(struct net_device *netdev,
51+
struct ethtool_link_ksettings *cmd)
5252
{
5353
struct spider_net_card *card;
5454
card = netdev_priv(netdev);
5555

56-
cmd->supported = (SUPPORTED_1000baseT_Full |
57-
SUPPORTED_FIBRE);
58-
cmd->advertising = (ADVERTISED_1000baseT_Full |
59-
ADVERTISED_FIBRE);
60-
cmd->port = PORT_FIBRE;
61-
ethtool_cmd_speed_set(cmd, card->phy.speed);
62-
cmd->duplex = DUPLEX_FULL;
56+
ethtool_link_ksettings_zero_link_mode(cmd, supported);
57+
ethtool_link_ksettings_add_link_mode(cmd, supported, 1000baseT_Full);
58+
ethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);
59+
60+
ethtool_link_ksettings_zero_link_mode(cmd, advertising);
61+
ethtool_link_ksettings_add_link_mode(cmd, advertising, 1000baseT_Full);
62+
ethtool_link_ksettings_add_link_mode(cmd, advertising, FIBRE);
63+
64+
cmd->base.port = PORT_FIBRE;
65+
cmd->base.speed = card->phy.speed;
66+
cmd->base.duplex = DUPLEX_FULL;
6367

6468
return 0;
6569
}
@@ -166,7 +170,6 @@ static void spider_net_get_strings(struct net_device *netdev, u32 stringset,
166170
}
167171

168172
const struct ethtool_ops spider_net_ethtool_ops = {
169-
.get_settings = spider_net_ethtool_get_settings,
170173
.get_drvinfo = spider_net_ethtool_get_drvinfo,
171174
.get_wol = spider_net_ethtool_get_wol,
172175
.get_msglevel = spider_net_ethtool_get_msglevel,
@@ -177,5 +180,6 @@ const struct ethtool_ops spider_net_ethtool_ops = {
177180
.get_strings = spider_net_get_strings,
178181
.get_sset_count = spider_net_get_sset_count,
179182
.get_ethtool_stats = spider_net_get_ethtool_stats,
183+
.get_link_ksettings = spider_net_ethtool_get_link_ksettings,
180184
};
181185

0 commit comments

Comments
 (0)