Skip to content

Commit 51df947

Browse files
harshimogalapallikuba-moo
authored andcommitted
octeontx2-pf: fix netdev memory leak in rvu_rep_create()
When rvu_rep_devlink_port_register() fails, free_netdev(ndev) for this incomplete iteration before going to "exit:" label. Fixes: 9ed0343 ("octeontx2-pf: Add devlink port support") Reviewed-by: Przemek Kitszel <[email protected]> Signed-off-by: Harshit Mogalapalli <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 5eecd85 commit 51df947

File tree

1 file changed

+3
-1
lines changed
  • drivers/net/ethernet/marvell/octeontx2/nic

1 file changed

+3
-1
lines changed

drivers/net/ethernet/marvell/octeontx2/nic/rep.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -680,8 +680,10 @@ int rvu_rep_create(struct otx2_nic *priv, struct netlink_ext_ack *extack)
680680
ndev->features |= ndev->hw_features;
681681
eth_hw_addr_random(ndev);
682682
err = rvu_rep_devlink_port_register(rep);
683-
if (err)
683+
if (err) {
684+
free_netdev(ndev);
684685
goto exit;
686+
}
685687

686688
SET_NETDEV_DEVLINK_PORT(ndev, &rep->dl_port);
687689
err = register_netdev(ndev);

0 commit comments

Comments
 (0)