Skip to content

Commit 5311598

Browse files
Saravanan VajravelPaolo Abeni
authored andcommitted
bnxt_en: Reserve rings after PCIe AER recovery if NIC interface is down
After successful PCIe AER recovery, FW will reset all resource reservations. If it is IF_UP, the driver will call bnxt_open() and all resources will be reserved again. It it is IF_DOWN, we should call bnxt_reserve_rings() so that we can reserve resources including RoCE resources to allow RoCE to resume after AER. Without this patch, RoCE fails to resume in this IF_DOWN scenario. Later, if it becomes IF_UP, bnxt_open() will see that resources have been reserved and will not reserve again. Fixes: fb1e6e5 ("bnxt_en: Fix AER recovery.") Reviewed-by: Somnath Kotur <[email protected]> Reviewed-by: Pavan Chebbi <[email protected]> Reviewed-by: Kashyap Desai <[email protected]> Signed-off-by: Saravanan Vajravel <[email protected]> Signed-off-by: Michael Chan <[email protected]> Signed-off-by: Paolo Abeni <[email protected]>
1 parent 9cfb5e7 commit 5311598

File tree

1 file changed

+6
-2
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+6
-2
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16478,8 +16478,12 @@ static void bnxt_io_resume(struct pci_dev *pdev)
1647816478
rtnl_lock();
1647916479

1648016480
err = bnxt_hwrm_func_qcaps(bp);
16481-
if (!err && netif_running(netdev))
16482-
err = bnxt_open(netdev);
16481+
if (!err) {
16482+
if (netif_running(netdev))
16483+
err = bnxt_open(netdev);
16484+
else
16485+
err = bnxt_reserve_rings(bp, true);
16486+
}
1648316487

1648416488
if (!err)
1648516489
netif_device_attach(netdev);

0 commit comments

Comments
 (0)