Skip to content

Commit 5512320

Browse files
committed
Merge tag 'fsdax-fix-5.1-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm
Pull fsdax fix from Dan Williams: "A single filesystem-dax fix. It has been lingering in -next for a long while and there are no other fsdax fixes on the horizon: - Avoid a crash scenario with architectures like powerpc that require 'pgtable_deposit' for the zero page" * tag 'fsdax-fix-5.1-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm: fs/dax: Deposit pagetable even when installing zero page
2 parents dc4060a + 11cf9d8 commit 5512320

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

fs/dax.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
#include <linux/sizes.h>
3434
#include <linux/mmu_notifier.h>
3535
#include <linux/iomap.h>
36+
#include <asm/pgalloc.h>
3637
#include "internal.h"
3738

3839
#define CREATE_TRACE_POINTS
@@ -1407,7 +1408,9 @@ static vm_fault_t dax_pmd_load_hole(struct xa_state *xas, struct vm_fault *vmf,
14071408
{
14081409
struct address_space *mapping = vmf->vma->vm_file->f_mapping;
14091410
unsigned long pmd_addr = vmf->address & PMD_MASK;
1411+
struct vm_area_struct *vma = vmf->vma;
14101412
struct inode *inode = mapping->host;
1413+
pgtable_t pgtable = NULL;
14111414
struct page *zero_page;
14121415
spinlock_t *ptl;
14131416
pmd_t pmd_entry;
@@ -1422,12 +1425,22 @@ static vm_fault_t dax_pmd_load_hole(struct xa_state *xas, struct vm_fault *vmf,
14221425
*entry = dax_insert_entry(xas, mapping, vmf, *entry, pfn,
14231426
DAX_PMD | DAX_ZERO_PAGE, false);
14241427

1428+
if (arch_needs_pgtable_deposit()) {
1429+
pgtable = pte_alloc_one(vma->vm_mm);
1430+
if (!pgtable)
1431+
return VM_FAULT_OOM;
1432+
}
1433+
14251434
ptl = pmd_lock(vmf->vma->vm_mm, vmf->pmd);
14261435
if (!pmd_none(*(vmf->pmd))) {
14271436
spin_unlock(ptl);
14281437
goto fallback;
14291438
}
14301439

1440+
if (pgtable) {
1441+
pgtable_trans_huge_deposit(vma->vm_mm, vmf->pmd, pgtable);
1442+
mm_inc_nr_ptes(vma->vm_mm);
1443+
}
14311444
pmd_entry = mk_pmd(zero_page, vmf->vma->vm_page_prot);
14321445
pmd_entry = pmd_mkhuge(pmd_entry);
14331446
set_pmd_at(vmf->vma->vm_mm, pmd_addr, vmf->pmd, pmd_entry);
@@ -1436,6 +1449,8 @@ static vm_fault_t dax_pmd_load_hole(struct xa_state *xas, struct vm_fault *vmf,
14361449
return VM_FAULT_NOPAGE;
14371450

14381451
fallback:
1452+
if (pgtable)
1453+
pte_free(vma->vm_mm, pgtable);
14391454
trace_dax_pmd_load_hole_fallback(inode, vmf, zero_page, *entry);
14401455
return VM_FAULT_FALLBACK;
14411456
}

0 commit comments

Comments
 (0)