Skip to content

Commit 5588b29

Browse files
geliangtangmpe
authored andcommitted
powerpc/powernv: use memdup_user
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang <[email protected]> Signed-off-by: Michael Ellerman <[email protected]>
1 parent 31f8eb7 commit 5588b29

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

arch/powerpc/platforms/powernv/opal-prd.c

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -241,23 +241,16 @@ static ssize_t opal_prd_write(struct file *file, const char __user *buf,
241241

242242
size = be16_to_cpu(hdr.size);
243243

244-
msg = kmalloc(size, GFP_KERNEL);
245-
if (!msg)
246-
return -ENOMEM;
247-
248-
rc = copy_from_user(msg, buf, size);
249-
if (rc) {
250-
size = -EFAULT;
251-
goto out_free;
252-
}
244+
msg = memdup_user(buf, size);
245+
if (IS_ERR(msg))
246+
return PTR_ERR(msg);
253247

254248
rc = opal_prd_msg(msg);
255249
if (rc) {
256250
pr_warn("write: opal_prd_msg returned %d\n", rc);
257251
size = -EIO;
258252
}
259253

260-
out_free:
261254
kfree(msg);
262255

263256
return size;

0 commit comments

Comments
 (0)