serial: imx: remove unneeded imx_transmit_buffer() from imx_start_tx()

dirkbehme · gregkh · commit 55c3cb1358e5 · 2015-01-09T14:23:07.000-08:00
Use imx_start_tx() just to enable the TX interrupt. It's the job of the
TX interrupt ISR to fill the transmit buffer, then. If the transmit buffer
is empty, the TX interrupt should be executed as soon as the start_tx()
enables the interrupt, so there is no reason for the extra
imx_transmit_buffer() call, here. Remove it.

Signed-off-by: Dirk Behme &lt;dirk.behme@de.bosch.com&gt;
Signed-off-by: Andy Lowe &lt;andy_lowe@mentor.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
@@ -621,9 +621,6 @@ static void imx_start_tx(struct uart_port *port)
 			imx_dma_tx(sport);
 		return;
 	}
-
-	if (readl(sport->port.membase + uts_reg(sport)) & UTS_TXEMPTY)
-		imx_transmit_buffer(sport);
 }
 
 static irqreturn_t imx_rtsint(int irq, void *dev_id)

Original file line number	Diff line number	Diff line change
`@@ -621,9 +621,6 @@ static void imx_start_tx(struct uart_port *port)`
`621`	`621`	`imx_dma_tx(sport);`
`622`	`622`	`return;`
`623`	`623`	`}`
`624`		`-`
`625`		`- if (readl(sport->port.membase + uts_reg(sport)) & UTS_TXEMPTY)`
`626`		`- imx_transmit_buffer(sport);`
`627`	`624`	`}`
`628`	`625`
`629`	`626`	`static irqreturn_t imx_rtsint(int irq, void *dev_id)`