Skip to content

Commit 5668821

Browse files
calmisibonzini
authored andcommitted
KVM: x86: Move kvm_x86_ops.vcpu_after_set_cpuid() into kvm_vcpu_after_set_cpuid()
kvm_x86_ops.vcpu_after_set_cpuid() is used to update vmx/svm specific vcpu settings based on updated CPUID settings. So it's supposed to be called after CPUIDs are updated, i.e., kvm_update_cpuid_runtime(). Currently, kvm_update_cpuid_runtime() only updates CPUID bits of OSXSAVE, APIC, OSPKE, MWAIT, KVM_FEATURE_PV_UNHALT and CPUID(0xD,0).ebx and CPUID(0xD, 1).ebx. None of them is consumed by vmx/svm's update_vcpu_after_set_cpuid(). So there is no dependency between them. Move kvm_x86_ops.vcpu_after_set_cpuid() into kvm_vcpu_after_set_cpuid() is obviously more reasonable. Signed-off-by: Xiaoyao Li <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1 parent 7c1b761 commit 5668821

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/x86/kvm/cpuid.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ static void kvm_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu)
121121
struct kvm_lapic *apic = vcpu->arch.apic;
122122
struct kvm_cpuid_entry2 *best;
123123

124+
kvm_x86_ops.vcpu_after_set_cpuid(vcpu);
125+
124126
best = kvm_find_cpuid_entry(vcpu, 1, 0);
125127
if (best && apic) {
126128
if (cpuid_entry_has(best, X86_FEATURE_TSC_DEADLINE_TIMER))
@@ -228,7 +230,6 @@ int kvm_vcpu_ioctl_set_cpuid(struct kvm_vcpu *vcpu,
228230
}
229231

230232
cpuid_fix_nx_cap(vcpu);
231-
kvm_x86_ops.vcpu_after_set_cpuid(vcpu);
232233
kvm_update_cpuid_runtime(vcpu);
233234
kvm_vcpu_after_set_cpuid(vcpu);
234235

@@ -257,7 +258,6 @@ int kvm_vcpu_ioctl_set_cpuid2(struct kvm_vcpu *vcpu,
257258
goto out;
258259
}
259260

260-
kvm_x86_ops.vcpu_after_set_cpuid(vcpu);
261261
kvm_update_cpuid_runtime(vcpu);
262262
kvm_vcpu_after_set_cpuid(vcpu);
263263
out:

0 commit comments

Comments
 (0)