Skip to content

Commit 568b445

Browse files
Srivatsa S. Bhattorvalds
authored andcommitted
mn10300/CPU hotplug: Add missing call to notify_cpu_starting()
The scheduler depends on receiving the CPU_STARTING notification, without which we end up into a lot of trouble. So add the missing call to notify_cpu_starting() in the bringup code. Signed-off-by: Srivatsa S. Bhat <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent ec2e0f9 commit 568b445

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

arch/mn10300/kernel/smp.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
#include <linux/sched.h>
2525
#include <linux/profile.h>
2626
#include <linux/smp.h>
27+
#include <linux/cpu.h>
2728
#include <asm/tlbflush.h>
2829
#include <asm/bitops.h>
2930
#include <asm/processor.h>
@@ -38,7 +39,6 @@
3839
#include "internal.h"
3940

4041
#ifdef CONFIG_HOTPLUG_CPU
41-
#include <linux/cpu.h>
4242
#include <asm/cacheflush.h>
4343

4444
static unsigned long sleep_mode[NR_CPUS];
@@ -874,10 +874,13 @@ static void __init smp_online(void)
874874

875875
cpu = smp_processor_id();
876876

877-
local_irq_enable();
877+
notify_cpu_starting(cpu);
878878

879+
ipi_call_lock();
879880
set_cpu_online(cpu, true);
880-
smp_wmb();
881+
ipi_call_unlock();
882+
883+
local_irq_enable();
881884
}
882885

883886
/**

0 commit comments

Comments
 (0)