Skip to content

Commit 56bf877

Browse files
Jiri Bencborkmann
authored andcommitted
selftests, bpf: xdping is not meant to be run standalone
The actual test to run is test_xdping.sh, which is already in TEST_PROGS. The xdping program alone is not runnable with 'make run_tests', it immediatelly fails due to missing arguments. Move xdping to TEST_GEN_PROGS_EXTENDED in order to be built but not run. Fixes: cd53850 ("selftests/bpf: measure RTT from xdp using xdping") Signed-off-by: Jiri Benc <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Reviewed-by: Alan Maguire <[email protected]> Acked-by: Toke Høiland-Jørgensen <[email protected]> Link: https://lore.kernel.org/bpf/4365c81198f62521344c2215909634407184387e.1573821726.git.jbenc@redhat.com
1 parent b97e12e commit 56bf877

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/testing/selftests/bpf/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map test_lpm_map test
3030
test_sock test_btf test_sockmap get_cgroup_id_user test_socket_cookie \
3131
test_cgroup_storage test_select_reuseport \
3232
test_netcnt test_tcpnotify_user test_sock_fields test_sysctl test_hashmap \
33-
test_cgroup_attach xdping test_progs-no_alu32
33+
test_cgroup_attach test_progs-no_alu32
3434

3535
# Also test bpf-gcc, if present
3636
ifneq ($(BPF_GCC),)
@@ -71,7 +71,7 @@ TEST_PROGS_EXTENDED := with_addr.sh \
7171
# Compile but not part of 'make run_tests'
7272
TEST_GEN_PROGS_EXTENDED = test_sock_addr test_skb_cgroup_id_user \
7373
flow_dissector_load test_flow_dissector test_tcp_check_syncookie_user \
74-
test_lirc_mode2_user
74+
test_lirc_mode2_user xdping
7575

7676
TEST_CUSTOM_PROGS = urandom_read
7777

0 commit comments

Comments
 (0)