Skip to content

Commit 56d18f6

Browse files
Ming Leiaxboe
authored andcommitted
block: kill BLK_MQ_F_SG_MERGE
QUEUE_FLAG_NO_SG_MERGE has been killed, so kill BLK_MQ_F_SG_MERGE too. Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Omar Sandoval <[email protected]> Signed-off-by: Ming Lei <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 2705c93 commit 56d18f6

File tree

10 files changed

+7
-11
lines changed

10 files changed

+7
-11
lines changed

block/blk-mq-debugfs.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,6 @@ static const char *const alloc_policy_name[] = {
249249
static const char *const hctx_flag_name[] = {
250250
HCTX_FLAG_NAME(SHOULD_MERGE),
251251
HCTX_FLAG_NAME(TAG_SHARED),
252-
HCTX_FLAG_NAME(SG_MERGE),
253252
HCTX_FLAG_NAME(BLOCKING),
254253
HCTX_FLAG_NAME(NO_SCHED),
255254
};

drivers/block/loop.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1937,7 +1937,7 @@ static int loop_add(struct loop_device **l, int i)
19371937
lo->tag_set.queue_depth = 128;
19381938
lo->tag_set.numa_node = NUMA_NO_NODE;
19391939
lo->tag_set.cmd_size = sizeof(struct loop_cmd);
1940-
lo->tag_set.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_SG_MERGE;
1940+
lo->tag_set.flags = BLK_MQ_F_SHOULD_MERGE;
19411941
lo->tag_set.driver_data = lo;
19421942

19431943
err = blk_mq_alloc_tag_set(&lo->tag_set);

drivers/block/nbd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1571,7 +1571,7 @@ static int nbd_dev_add(int index)
15711571
nbd->tag_set.numa_node = NUMA_NO_NODE;
15721572
nbd->tag_set.cmd_size = sizeof(struct nbd_cmd);
15731573
nbd->tag_set.flags = BLK_MQ_F_SHOULD_MERGE |
1574-
BLK_MQ_F_SG_MERGE | BLK_MQ_F_BLOCKING;
1574+
BLK_MQ_F_BLOCKING;
15751575
nbd->tag_set.driver_data = nbd;
15761576

15771577
err = blk_mq_alloc_tag_set(&nbd->tag_set);

drivers/block/rbd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3988,7 +3988,7 @@ static int rbd_init_disk(struct rbd_device *rbd_dev)
39883988
rbd_dev->tag_set.ops = &rbd_mq_ops;
39893989
rbd_dev->tag_set.queue_depth = rbd_dev->opts->queue_depth;
39903990
rbd_dev->tag_set.numa_node = NUMA_NO_NODE;
3991-
rbd_dev->tag_set.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_SG_MERGE;
3991+
rbd_dev->tag_set.flags = BLK_MQ_F_SHOULD_MERGE;
39923992
rbd_dev->tag_set.nr_hw_queues = 1;
39933993
rbd_dev->tag_set.cmd_size = sizeof(struct work_struct);
39943994

drivers/block/skd_main.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2843,7 +2843,6 @@ static int skd_cons_disk(struct skd_device *skdev)
28432843
skdev->sgs_per_request * sizeof(struct scatterlist);
28442844
skdev->tag_set.numa_node = NUMA_NO_NODE;
28452845
skdev->tag_set.flags = BLK_MQ_F_SHOULD_MERGE |
2846-
BLK_MQ_F_SG_MERGE |
28472846
BLK_ALLOC_POLICY_TO_MQ_FLAG(BLK_TAG_ALLOC_FIFO);
28482847
skdev->tag_set.driver_data = skdev;
28492848
rc = blk_mq_alloc_tag_set(&skdev->tag_set);

drivers/block/xen-blkfront.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -977,7 +977,7 @@ static int xlvbd_init_blk_queue(struct gendisk *gd, u16 sector_size,
977977
} else
978978
info->tag_set.queue_depth = BLK_RING_SIZE(info);
979979
info->tag_set.numa_node = NUMA_NO_NODE;
980-
info->tag_set.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_SG_MERGE;
980+
info->tag_set.flags = BLK_MQ_F_SHOULD_MERGE;
981981
info->tag_set.cmd_size = sizeof(struct blkif_req);
982982
info->tag_set.driver_data = info;
983983

drivers/md/dm-rq.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,7 @@ int dm_mq_init_request_queue(struct mapped_device *md, struct dm_table *t)
527527
md->tag_set->ops = &dm_mq_ops;
528528
md->tag_set->queue_depth = dm_get_blk_mq_queue_depth();
529529
md->tag_set->numa_node = md->numa_node_id;
530-
md->tag_set->flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_SG_MERGE;
530+
md->tag_set->flags = BLK_MQ_F_SHOULD_MERGE;
531531
md->tag_set->nr_hw_queues = dm_get_blk_mq_nr_hw_queues();
532532
md->tag_set->driver_data = md;
533533

drivers/mmc/core/queue.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -410,8 +410,7 @@ int mmc_init_queue(struct mmc_queue *mq, struct mmc_card *card)
410410
else
411411
mq->tag_set.queue_depth = MMC_QUEUE_DEPTH;
412412
mq->tag_set.numa_node = NUMA_NO_NODE;
413-
mq->tag_set.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_SG_MERGE |
414-
BLK_MQ_F_BLOCKING;
413+
mq->tag_set.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_BLOCKING;
415414
mq->tag_set.nr_hw_queues = 1;
416415
mq->tag_set.cmd_size = sizeof(struct mmc_queue_req);
417416
mq->tag_set.driver_data = mq;

drivers/scsi/scsi_lib.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1899,7 +1899,7 @@ int scsi_mq_setup_tags(struct Scsi_Host *shost)
18991899
shost->tag_set.queue_depth = shost->can_queue;
19001900
shost->tag_set.cmd_size = cmd_size;
19011901
shost->tag_set.numa_node = NUMA_NO_NODE;
1902-
shost->tag_set.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_SG_MERGE;
1902+
shost->tag_set.flags = BLK_MQ_F_SHOULD_MERGE;
19031903
shost->tag_set.flags |=
19041904
BLK_ALLOC_POLICY_TO_MQ_FLAG(shost->hostt->tag_alloc_policy);
19051905
shost->tag_set.driver_data = shost;

include/linux/blk-mq.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@ struct blk_mq_ops {
218218
enum {
219219
BLK_MQ_F_SHOULD_MERGE = 1 << 0,
220220
BLK_MQ_F_TAG_SHARED = 1 << 1,
221-
BLK_MQ_F_SG_MERGE = 1 << 2,
222221
BLK_MQ_F_BLOCKING = 1 << 5,
223222
BLK_MQ_F_NO_SCHED = 1 << 6,
224223
BLK_MQ_F_ALLOC_POLICY_START_BIT = 8,

0 commit comments

Comments
 (0)