Skip to content

Commit 57127da

Browse files
Ahmed S. DarwishKAGA-KOKO
authored andcommitted
PCI/MSI: Move pci_msi_restore_state() to api.c
To disentangle the maze in msi.c, all exported device-driver MSI APIs are now to be grouped in one file, api.c. Move pci_msi_enabled() and add kernel-doc for the function. Signed-off-by: Ahmed S. Darwish <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Acked-by: Bjorn Helgaas <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 897a0b6 commit 57127da

File tree

3 files changed

+19
-9
lines changed

3 files changed

+19
-9
lines changed

drivers/pci/msi/api.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,21 @@ void pci_free_irq_vectors(struct pci_dev *dev)
308308
}
309309
EXPORT_SYMBOL(pci_free_irq_vectors);
310310

311+
/**
312+
* pci_restore_msi_state() - Restore cached MSI(-X) state on device
313+
* @dev: the PCI device to operate on
314+
*
315+
* Write the Linux-cached MSI(-X) state back on device. This is
316+
* typically useful upon system resume, or after an error-recovery PCI
317+
* adapter reset.
318+
*/
319+
void pci_restore_msi_state(struct pci_dev *dev)
320+
{
321+
__pci_restore_msi_state(dev);
322+
__pci_restore_msix_state(dev);
323+
}
324+
EXPORT_SYMBOL_GPL(pci_restore_msi_state);
325+
311326
/**
312327
* pci_msi_enabled() - Are MSI(-X) interrupts enabled system-wide?
313328
*

drivers/pci/msi/msi.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ bool __weak arch_restore_msi_irqs(struct pci_dev *dev)
199199
return true;
200200
}
201201

202-
static void __pci_restore_msi_state(struct pci_dev *dev)
202+
void __pci_restore_msi_state(struct pci_dev *dev)
203203
{
204204
struct msi_desc *entry;
205205
u16 control;
@@ -231,7 +231,7 @@ static void pci_msix_clear_and_set_ctrl(struct pci_dev *dev, u16 clear, u16 set)
231231
pci_write_config_word(dev, dev->msix_cap + PCI_MSIX_FLAGS, ctrl);
232232
}
233233

234-
static void __pci_restore_msix_state(struct pci_dev *dev)
234+
void __pci_restore_msix_state(struct pci_dev *dev)
235235
{
236236
struct msi_desc *entry;
237237
bool write_msg;
@@ -257,13 +257,6 @@ static void __pci_restore_msix_state(struct pci_dev *dev)
257257
pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_MASKALL, 0);
258258
}
259259

260-
void pci_restore_msi_state(struct pci_dev *dev)
261-
{
262-
__pci_restore_msi_state(dev);
263-
__pci_restore_msix_state(dev);
264-
}
265-
EXPORT_SYMBOL_GPL(pci_restore_msi_state);
266-
267260
static void pcim_msi_release(void *pcidev)
268261
{
269262
struct pci_dev *dev = pcidev;

drivers/pci/msi/msi.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ void pci_free_msi_irqs(struct pci_dev *dev);
9494
int __pci_enable_msi_range(struct pci_dev *dev, int minvec, int maxvec, struct irq_affinity *affd);
9595
int __pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries, int minvec,
9696
int maxvec, struct irq_affinity *affd, int flags);
97+
void __pci_restore_msi_state(struct pci_dev *dev);
98+
void __pci_restore_msix_state(struct pci_dev *dev);
9799

98100
/* Legacy (!IRQDOMAIN) fallbacks */
99101

0 commit comments

Comments
 (0)