Skip to content

Commit 57a3714

Browse files
author
J. Bruce Fields
committed
nfsd4: CREATE_SESSION should update backchannel immediately
nfsd4_probe_callback kicks off some work that will eventually run nfsd4_process_cb_update and update the session flags. In theory we could process a following SEQUENCE call before that update happens resulting in flags that don't accurately represent, for example, the lack of a backchannel. Signed-off-by: J. Bruce Fields <[email protected]>
1 parent 22cb438 commit 57a3714

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

fs/nfsd/nfs4state.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1223,10 +1223,8 @@ static void nfsd4_init_conn(struct svc_rqst *rqstp, struct nfsd4_conn *conn, str
12231223
if (ret)
12241224
/* oops; xprt is already down: */
12251225
nfsd4_conn_lost(&conn->cn_xpt_user);
1226-
if (conn->cn_flags & NFS4_CDFC4_BACK) {
1227-
/* callback channel may be back up */
1228-
nfsd4_probe_callback(ses->se_client);
1229-
}
1226+
/* We may have gained or lost a callback channel: */
1227+
nfsd4_probe_callback_sync(ses->se_client);
12301228
}
12311229

12321230
static struct nfsd4_conn *alloc_conn_from_crses(struct svc_rqst *rqstp, struct nfsd4_create_session *cses)

0 commit comments

Comments
 (0)