Skip to content

Commit 57b354e

Browse files
NicolasDichteldavem330
authored andcommitted
dev: remove duplicate 'skb->dev = dev' in dev_forward_skb()
This was added by commit 59b9997 (Revert "net: maintain namespace isolation between vlan and real device"). In fact, before the initial commit - the one that is reverted -, this statement was not present. 'skb->dev = dev' is already done in eth_type_trans(), which is call just after. Spotted-by: Alain Ritoux <[email protected]> Signed-off-by: Nicolas Dichtel <[email protected]> Acked-by: Eric Dumazet <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b103f35 commit 57b354e

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

net/core/dev.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1629,7 +1629,6 @@ int dev_forward_skb(struct net_device *dev, struct sk_buff *skb)
16291629
return NET_RX_DROP;
16301630
}
16311631
skb->skb_iif = 0;
1632-
skb->dev = dev;
16331632
skb_dst_drop(skb);
16341633
skb->tstamp.tv64 = 0;
16351634
skb->pkt_type = PACKET_HOST;

0 commit comments

Comments
 (0)