Skip to content

Commit 584c005

Browse files
rostedtpaulmck
authored andcommitted
tracing, rcu: Remove no longer used trace event rcu_prep_idle
Commit c0f4dfd ("rcu: Make RCU_FAST_NO_HZ take advantage of numbered callbacks") removed the only instances of trace_rcu_prep_idle, but did not remove the TRACE_EVENT() that creates it. As defined trace events take up memory within the kernel even when they are not used, this is a waste of space. Remove the obsolete event. Signed-off-by: Steven Rostedt (VMware) <[email protected]> Signed-off-by: Paul E. McKenney <[email protected]>
1 parent 3af3999 commit 584c005

File tree

1 file changed

+0
-40
lines changed
  • include/trace/events

1 file changed

+0
-40
lines changed

include/trace/events/rcu.h

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -457,45 +457,6 @@ TRACE_EVENT(rcu_dyntick,
457457
__entry->dynticks & 0xfff)
458458
);
459459

460-
/*
461-
* Tracepoint for RCU preparation for idle, the goal being to get RCU
462-
* processing done so that the current CPU can shut off its scheduling
463-
* clock and enter dyntick-idle mode. One way to accomplish this is
464-
* to drain all RCU callbacks from this CPU, and the other is to have
465-
* done everything RCU requires for the current grace period. In this
466-
* latter case, the CPU will be awakened at the end of the current grace
467-
* period in order to process the remainder of its callbacks.
468-
*
469-
* These tracepoints take a string as argument:
470-
*
471-
* "No callbacks": Nothing to do, no callbacks on this CPU.
472-
* "In holdoff": Nothing to do, holding off after unsuccessful attempt.
473-
* "Begin holdoff": Attempt failed, don't retry until next jiffy.
474-
* "Dyntick with callbacks": Entering dyntick-idle despite callbacks.
475-
* "Dyntick with lazy callbacks": Entering dyntick-idle w/lazy callbacks.
476-
* "More callbacks": Still more callbacks, try again to clear them out.
477-
* "Callbacks drained": All callbacks processed, off to dyntick idle!
478-
* "Timer": Timer fired to cause CPU to continue processing callbacks.
479-
* "Demigrate": Timer fired on wrong CPU, woke up correct CPU.
480-
* "Cleanup after idle": Idle exited, timer canceled.
481-
*/
482-
TRACE_EVENT(rcu_prep_idle,
483-
484-
TP_PROTO(const char *reason),
485-
486-
TP_ARGS(reason),
487-
488-
TP_STRUCT__entry(
489-
__field(const char *, reason)
490-
),
491-
492-
TP_fast_assign(
493-
__entry->reason = reason;
494-
),
495-
496-
TP_printk("%s", __entry->reason)
497-
);
498-
499460
/*
500461
* Tracepoint for the registration of a single RCU callback function.
501462
* The first argument is the type of RCU, the second argument is
@@ -803,7 +764,6 @@ TRACE_EVENT(rcu_barrier,
803764
while (0)
804765
#define trace_rcu_fqs(rcuname, gpnum, cpu, qsevent) do { } while (0)
805766
#define trace_rcu_dyntick(polarity, oldnesting, newnesting, dyntick) do { } while (0)
806-
#define trace_rcu_prep_idle(reason) do { } while (0)
807767
#define trace_rcu_callback(rcuname, rhp, qlen_lazy, qlen) do { } while (0)
808768
#define trace_rcu_kfree_callback(rcuname, rhp, offset, qlen_lazy, qlen) \
809769
do { } while (0)

0 commit comments

Comments
 (0)